aurorasloan/minishell

A simple shell

minishell

A simple shell.

This program was developed by Yuta-Fujimoto and AuroraSloan

Features

Simple commands

• Search and launch any executable in $PATH

Builtin commands

Command	Options / Arguments
echo	-n
cd	relitvie or absolute path
pwd	n/a
export	no options
unset	no options
env	n/a
exit	no options

Expansion

• ' inhibits all interpretions of a sequence of characters
• " inhibits all interpretation of a sequence of characters except for $
• Environment values expand to their values
• $? expands to the most recently executed foreground pipeline

Redirection

• < redirects input
• > redirects output
• << reads input from the current source until a linie containing only the delimiter is seen
• >> redirects output with append mode

Piping

• The output of each command in the pipeline is connected via a pipe to the input of the next command

Signals

• Ctrl-c prints a new prompt on a new line
• Ctrl-d exits the shell
• Ctrl-\ does nothing

---

Installation

git clone https://github.com/AuroraSloan/minishell.git

---

Usage

First, create the executable with make
make - compiles the minishell executable
make clean - removes all object files
make fclean - removes all object files and the executable
make re - removes all object files and the executable before recompiling the program

In order to run the program, simply run the executable.

./minishell

To exit the program, you can use the builtin command exit or press Ctrl-d.

minishell's Issues

bash: unset: `+=': not a valid identifier

bash: unset: `+=': not a valid identifier
これ back quote
export もそうです

cat | cat | ls

waitpid is called by newline or ;
it may not be called by the end of each execution (execve or builtin)

don't distinguish pwd and PWD

command PWD successes on bash!!

environ memory leak

add free_environ when the end of minishell

we may should use valgrind to check memory leak!!!(test.sh shou;d be rewrited)

export HOME=; cd ; pwd

この場合no such file or direcitory ではないです

unset path

unset pathしたあと、何かコマンドを焼ければerrorを出てminishellから出ます

minishell > unset PATH
minishell > ls
minishell:error

今修正してみます

env + argument

bash は no such file or directoryを書いているけど mshは　無視してenvを表現します

echo "echo hello" > a; chmod 300 a ; a

minishell だと
minishell > ./a
でなにもしない
bash-3.2$ ./a
bash: ./a: Permission denied
これはまだどうしたらいいかわかりません

644は同じ

Error handling for dup(), dup2(), open(), close() in pipeline

if result is -1 from any of these functions, need to exit shell
currently not being handled

malloc error handling in lexer and parser

lexarはほとんど大丈夫ですけどmalloc errorがあれば、readlineのinputをfreeしないexitをしていると思います。
parserはいろいろな変更しなければならないと思います

lexarのメモリリーク

ex) "ls " blanks are not freed?

syntax errorの時にsegment faultになる

ls | grep a |　

a.out should be failure when ./a.out is success

a.out is command and ./a.out is file path ??

export aaaaaaa; export

declare -x TMPDIR="/var/folders/zz/zyxvpxvq6csfxvn_n0000rx4000679/T/"
declare -x USER="fyuta"
declare -x aaaaa

こんな感じ
envだと出力しない
これはひとつのpull requestでやります

exit - 1　出る書くことが違うエラー

私はあまり気にしないけどゆたさんはそれは大切があるかどうかわからないです
exit -- 1を確認しているときこれを見ました
exit - 1　をかけば
too many argumentsを書いているけど、bash は　numeric argument requiredのエラーを書いています

exit -- 1

-- をスキップ

syntax error if > is not followed by anything

malloc error in parser and lexer

cd symbolic link

bash-3.2$ mkdir dir
bash-3.2$ ln -s dir symdir
bash-3.2$ cd symdir
bash-3.2$ pwd
/Users/fyuta/symdir
bash-3.2$

echo hello | < a echo

command not found

<< A | cat segv

??????????????

$0 == bash ???

0 is not enviromental variable

echo $0

parser memory leak

< fn cat , > fn echo aaaa
when redirection is top, it occurs

exit 0 0; ls

if ac >= 3 in exit, it doesn't execute and ls isn't executed, too !!

return value in ft_export_* should be FAILURE or SUCCESS

前にこれについて聞いてもらってました。その時に直せばよかったですね。すみません、、、

export A=" "

not a valid identifier ではない

expansion memory leaks if <redirection> NO_FILE

ex )< NO_FILE cat
it also occurs if permission dinied

increase env SHLVL when minishell is called in minishell program

env | grep SHLVL

PATH="" やunset PATH, PATH="::::::" のときの対応

cp /bin/ls ./
unset PATH
ls

current_direcitoy + lsですね

memory leak when using redirection and command not found happens

$? > file.txt
hey > file.txt

export CDPATH="./"; mkdir dir; cd dir;

これは＄PWDを出力します

error message of "nocmd" and "./nocmd"

this is related to #20 ??

echo "'<<<'"

syntax errorになります
lexarを直す

~ tilde should expand to home directory

cat & ctrl -c error

普通にcatを使っていて、ctrl -c　をかけば、minishellから出ないけど、「minishell:error」を表現しています