Comments (4)
Hi @lionhylra, thanks for raising this.
I'm unable to reproduce this issue; both error and success results are being delivered on the main thread. Which specific error are you triggering?
from auth0.swift.
I did web auth on a client who's authentication method is POST. This will trigger .pkceNotAllowed
error, but the callback was executed on a background queue. As I mentioned in the issue description, it was this line of code:
Auth0.swift/Auth0/OAuth2Grant.swift
Line 84 in d621132
from auth0.swift.
Thanks for the clarification. The long-standing convention on Apple plaftorms is to execute callbacks in whatever queue the last operation was executed. Following this, as you mentioned, we don't specify in our docs that the callbacks will be called in any specific queue. However, I agree that given the need to deal with UI updates shortly after in case of error, calling it on the main thread would improve the developer experience.
I don't have an ETA for this, but I'll leave this open for future planning and reference.
from auth0.swift.
Hi, given that:
- Addressing this on the current major could lead to unnecessarily dispatching to the main queue twice (once by Auth0.swift, and then again by the current application code)
- Even though always delivering the result on the main thread would improve DX, it's a nice-to-have
- The current behavior follows a long-standing convention
We'll defer this improvement to the next (future) major. I've already made a note of this, so I'll go ahead and close this issue.
Thanks for bringing this to our attention!
from auth0.swift.
Related Issues (20)
- In v2 we can no longer build out our own token request HOT 9
- Login with OTP with custom realm HOT 1
- Custom minTTL support with renew() API HOT 2
- Passwordless authentication does not accept additional parameters HOT 2
- Privacy Manfiest HOT 4
- SWIFT TASK CONTINUATION MISUSE: clearSession(federated:) leaked its continuation! HOT 2
- Auth0 does not support visionOS
- Missing AuthenticationError helper for Revoked tokens
- Auth0 does not support Social Logins for visionOS HOT 1
- isNetworkError does not report case where Wifi + Mobile Data is off HOT 1
- Auth0.webAuth() doesn't work during migration from iOS to VisionOS platform HOT 23
- Auth0 crashes due to swift task continuation misuse HOT 7
- Unable to install latest version. HOT 2
- Privacy manifest HOT 3
- signup func to support setting given_name and family_name HOT 2
- Auth0 podspec for iOS privacy info HOT 1
- Implementing additionalHeaderFields
- Getting "No credentials were found in the store." on production app HOT 3
- getting "No Credentails were found in the store" on production app HOT 1
- What is the correct way to work with CredentialsManager in Swift Concurrency?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from auth0.swift.