Auth0 crashes due to swift task continuation misuse

[erichoracek]

Auth0 crashes due to swift task continuation misuse

[Widcket]

Hi @erichoracek, thanks for raising this.

Would you happen to have any additional contextual information on this issue? For example, in this instance, it happened when the login button was rapidly tapped twice while the app window was not active yet.

[erichoracek]

Hi @Widcket, we don't have a lot of information since we can't reproduce these crashes, but both of these appear to about 5-10 seconds after a SFBrowserRemoteViewController is dismissed as part of user login.

[Widcket]

Unfortunately, without more information, there's not much we can do. I'm no longer the maintainer of this library, so I cannot dedicate more time to look into this.

[erichoracek]

We are in the same situation—we're unable to reproduce this locally. Since the crash is clear about the cause I'd assume it should be possible to make a fix by storing some state locally and checking it to ensure the continuation is invoked once, even if we don't know the root cause or have a repro case.

[Widcket]

I think I managed to reproduce it:

trim.877E1D84-FB87-422F-9B26-4DA1C45A1316.MOV

If this is is the same crash (please check in your crash reports) then it's due to a race condition because of the two login transactions happening at the same time.

[Widcket]

The above happens when tapping two of the login buttons at the same time (e.g. Google login and email/password login) logging in in one of the browser modals, and then very quickly pressing cancel on the second as soon as the first is dismissed.

As a race condition, it doesn't happen all the time, and is hard to get just right.

[Widcket]

It shouldn't be possible to open two browser modals at the same time, though.