Add ability to colorize cell content without breaking padding

[automattic]

Add ability to colorize cell content without breaking padding

[TooTallNate]

Hey @Marak. This sounds like a feature that should be implemented in colors.js IMO. It sounds like you should be altering the String.prototype.length getter in order to subtract the length of the ANSI color codes. This would fix the problem here, and any other potential lib that depends on String#length (which are probably out there).

Plus, if I do: 'Hello World!'.blue.length I would always expect it's length to be 12, and not 22. So this really does seem like a colors.js bug to me...

Just food for thought...

[TooTallNate]

Of course, the above it assuming that you're actually using colors.js. You never verified that in the OP, so I'm not sure...

[Marak]

I thought about messing with String.prototype.length but my javascript spider sense told me not to do it.

I'll try it anyway and see what happens.

Actual library is kinda irrelevant, problem applies to ANSI escape codes in strings meant for terminal output.

Thanks for the advice!

[TooTallNate]

I'd think String.prototype.length would be doable, so long as you're safe about it. And ya, I get that the ANSI codes in general are the problem, but your colors.js aims to be a convenience wrapper around those escape codes, so continuing to abstract them away from the String interface (i.e. also abstracting them out of String#length) would be a good thing IMO.

This way, cli-table doesn't need to even know about the ANSI escape code, which I think it shouldn't...

[Marak]

Fixed with #6. Thanks!