auxilor/reforges

Reforges plugin for the latest minecraft version

Source code for Reforges, a premium spigot plugin.

License

Click here to read the entire license.

reforges's Issues

Rich not working on Grief Prevention claim

Im not sure if rich is the problem or the "kill" trigger. When killing a mob in a claim even you are trusted nor have permissiontrust I can't earn money but if its my claim I can earn money. Hope this got fixed asap.

Multiple reforges

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
I think it would be really good for players to be able to add multiple reforges to an item
Describe the solution you'd like
A clear and concise description of what you want to happen.
Gain the ability to add more then 1 modifer to an item, for example (Strong, light wooden sword) But for each modifier to be incompatible with ones that modify the same stat
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
I've considered other plugins but haven't found anything as polished as this one.

Reforge on ecoarmor doesn't work

Reforge don't go after new versions to put on ecoarmor. In older versions it worked but it doesn't work anymore.

Server Information

• Version: 1.18.1 Purpur-1566
• Version of plugin and eco: eco 6.27.0, reforges: 4.47.1, ecoarmor: 7.35.1

Click-Drag-Drop İtem Disappear BUG

Describe the bug
Items disapper when you Click-Drag-Drop the item to the left slot and close the window.

To Reproduce
Steps to reproduce the behavior:

1. Open reforge window.
2. Click-Drag-Drop the item that you want to reforge to the left slot.
   #You 'll see red glass panel still over there. That means you can't reforge the item now. When you click to reforge button red glass panels turns to green glass panels. Now you can reforge and its safe to close the window.
3. Let the window close somehow.
4. BOOM! You found how Hawking Radiation works! #İtem disappers.

Screenshots

Server Information (please complete the following information):

More exact exp requirements/placeholders

I want players to be able to see the exact amount of levels or experience it will take to reforge an item, and the current placeholder only goes up in increments of 30 levels. It also does not account for the scaling that occurs for each exp level, and that 30 levels at lvl 500 is nowhere near the same exp as 30 lvls at lvl 100.

I would like to have the ability to set an exact exp cost per reforge, and have that be affected by the formula. I would also like the placeholder to give a more exact number relating to the exp cost to reforge.

Item Disappears if background is air

Describe the bug
If a player misplaces an item, while the background material is set to air/nothing, then it will "consume" the item, destroying it and making it impossible to get back.

To Reproduce
Steps to reproduce the behavior:

1. Set the config to this: https://paste.gg/p/anonymous/94e67e5e51104fe49e48238445718ccf
2. Get an item and place it inside an empty slot.
3. Item will may be retrievable if lucky, if so, continue until the item is "consumed"

Expected behavior
The GUI will reject the sword and not allow the player to put it in the GUI except inside the proper slot.

Screenshots
See gif here: https://i.imgur.com/29QQs3A.gif

Server Information (please complete the following information):

• Version: Pufferfish-56 (MC: 1.18.2)
• Eco 6.29.2 | Reforge 4.55.0

Cannot repair reforged items

Currently reforged items seem not to be able to be repaired. Tested with weapons and armor in an anvil.

Example, damaged netherite sword in the anvil, netherite ingot, result is the same damaged sword (but will take your ingot(s) if you take the resulted item).

%xp% not working

Hey, I got a problem when I try use %xp% its just not working.

• reforge version - 5.3.0
• eco version - 6.35.12

If need contact me: FableVania#6372

Discounted reforge rates ($) from permission node

The ability to discount the reforge cost from a permission could open a lot of possibilities for servers.

permission node example :reforges.costdiscount.10 would be something like 10% reduced cost.

[ENHANCEMENT] Add Reforges as MMOItems Item-Stats

As of now, the lore displaying the reforge is always locat3d at the bottom of an items lore. By adding the reforge display as a MMO Items Item-Stat like explained here, users would be able to position the reforge display further up, between- or above other MMOItems Item-Stats:

I opened an issue here because my ideas to add MMOItems support were overlooked two times on your discord server and it seems genuinely more organised to put it here

Thor Enchantment bug

Describe the bug
I have grief prevention and pvp toggle system, but with Thor it can lighting strike someone even if they have pvp off and it kills their animals even if is in a land claim area or tamed. I believe Thor enchantment probably isn't the only enchantment.

To Reproduce
Steps to reproduce the behavior:
I explained above.

Expected behavior
Expected the enchantment to not damage tamed or protected animals in land claim. And to not damage players when there pvp is toggle off.

Screenshots
I do not have a screenshot.

Server Information (please complete the following information):

• Version: Paper 1.18.2
• Version of plugin and eco: EcoEnchants v8.50.0 & eco-6.29.1-all

Additional context
Nope

Mainhand and offhand reforge stats stack!

Describe the bug
Mainhand and offhand reforge stats stack!

Expected behavior
Disable reforges in weapon when in offhand

Server Information (please complete the following information):

• Version: 1.18.1
• Version of plugin and eco (/ver eco-6.24.2-all, /ver <Reforges v4.44.2>)

Can't apply reforges to custom items

I can't apply reforges to anything that isn't a vanilla item
If I add * before every entry in target.yml it comes up with an error

Server Information (please complete the following information):

• Version: Paper 1.18.2-313
• Version of plugin and eco: Eco - 6.29.2, Reforges 4.61.4

Open to return item to inventory

It's very easy to fat-finger click the reforge icon twice (a few members have brought it up)

An option to return the item to your inventory upon successful reforge, and close the GUI would be nice.

Unable to use "$" or "coins" for reforge

I have the vault plugin setup and economy can be use in other shops , auction plugin , but I can't use $, coins in Reforges .
I have enough cash for reforge but the server keep telling me that I have not enough cash.

Junk data written to reforged item names, causes server crashes.

Occasionally after reforging an enchanted item, other held previously reforged items can have the Name NBT data spammed with extra shit, which on it's own isn't a problem, but if said item is then used for an event which would broadcast to chat/console (e.g. player killed player with [buggeditem]) the server will crash when attempting to read the trash data.

To Reproduce

1. Spawn in two enchanted weapons /minecraft:give @p netherite_sword{Enchantments:[{id:looting,lvl:3},{id:mending,lvl:1},{id:sharpness,lvl:5},{id:sweeping,lvl:3}]} 2
2. Reforge Item 1,
3. Reforge Item 2,
4. Check NBT data of both items.

• If no extra data has appeared on either item between display: {Lore: []}}, Count: 1b} in the NBT Data continue to reforge either/both items.
• When {Name: '{"italic":false,"extra":[{"italic":false,"extra":[{"translate":"item.minecraft.netherite_sword"}],"text":""}],"text":""}', appears between display: and {Lore: []}} the bug has been encountered

Expected behavior
No extra junk data to ever be added to the Name NBT data.

Screenshots

Log from Game output as I was attempting to find the cause of the junk data.

22:18:49.364 [CHAT] Gave 2 [Netherite Sword] to ql0u0lp
22:18:58.531 [CHAT] ql0u0lp has the following entity data: {id: "minecraft:netherite_sword", tag: {Damage: 0, display: {Lore: []}, Enchantments: [{id: "minecraft:bane_of_arthropods", lvl: 5s}, {id: "minecraft:fire_aspect", lvl: 2s}, {id: "minecraft:knockback", lvl: 2s}, {id: "minecraft:looting", lvl: 3s}, {id: "minecraft:sharpness", lvl: 5s}, {id: "minecraft:silk_touch", lvl: 1s}, {id: "minecraft:smite", lvl: 5s}, {id: "minecraft:sweeping", lvl: 3s}]}, Count: 1b}
22:19:11.415 [CHAT] ql0u0lp has the following entity data: {id: "minecraft:netherite_sword", tag: {Damage: 0, display: {Lore: []}, Enchantments: [{id: "minecraft:bane_of_arthropods", lvl: 5s}, {id: "minecraft:fire_aspect", lvl: 2s}, {id: "minecraft:knockback", lvl: 2s}, {id: "minecraft:looting", lvl: 3s}, {id: "minecraft:sharpness", lvl: 5s}, {id: "minecraft:silk_touch", lvl: 1s}, {id: "minecraft:smite", lvl: 5s}, {id: "minecraft:sweeping", lvl: 3s}]}, Count: 1b}
22:19:16.965 [CHAT] Reforges » Applied Sharp reforge!
22:19:21.283 [CHAT] ql0u0lp has the following entity data: {id: "minecraft:netherite_sword", tag: {Damage: 0, display: {Lore: []}, Enchantments: [{id: "minecraft:bane_of_arthropods", lvl: 5s}, {id: "minecraft:fire_aspect", lvl: 2s}, {id: "minecraft:knockback", lvl: 2s}, {id: "minecraft:looting", lvl: 3s}, {id: "minecraft:sharpness", lvl: 5s}, {id: "minecraft:silk_touch", lvl: 1s}, {id: "minecraft:smite", lvl: 5s}, {id: "minecraft:sweeping", lvl: 3s}]}, Count: 1b}
22:19:25.399 [CHAT] ql0u0lp has the following entity data: {id: "minecraft:netherite_sword", tag: {PublicBukkitValues: {"reforges:reforge": "sharp", "reforges:reforge_amount": 1}, Enchantments: [{id: "minecraft:bane_of_arthropods", lvl: 5s}, {id: "minecraft:fire_aspect", lvl: 2s}, {id: "minecraft:knockback", lvl: 2s}, {id: "minecraft:looting", lvl: 3s}, {id: "minecraft:sharpness", lvl: 5s}, {id: "minecraft:silk_touch", lvl: 1s}, {id: "minecraft:smite", lvl: 5s}, {id: "minecraft:sweeping", lvl: 3s}], Damage: 0, display: {Lore: []}}, Count: 1b}
22:19:39.183 [CHAT] Reforges » Applied Gravitated reforge!
22:19:39.334 [CHAT] Reforges » Applied Strong reforge!
22:19:39.483 [CHAT] Reforges » Applied Sharp reforge!
22:19:39.634 [CHAT] Reforges » Applied Strong reforge!
22:19:39.767 [CHAT] Reforges » Applied Gravitated reforge!
22:19:39.934 [CHAT] Reforges » Applied Nautical reforge!
22:19:40.083 [CHAT] Reforges » Applied Gravitated reforge!
22:19:40.250 [CHAT] Reforges » Applied Light reforge!
22:19:40.400 [CHAT] Reforges » Applied Gravitated reforge!
22:19:40.583 [CHAT] Reforges » Applied Sharp reforge!
22:19:40.750 [CHAT] Reforges » Applied Strong reforge!
22:19:40.900 [CHAT] Reforges » Applied Sharp reforge!
22:19:41.050 [CHAT] Reforges » Applied Light reforge!
22:19:41.200 [CHAT] Reforges » Applied Gravitated reforge!
22:19:45.834 [CHAT] ql0u0lp has the following entity data: {id: "minecraft:netherite_sword", tag: {PublicBukkitValues: {"reforges:reforge": "gravitated", "reforges:reforge_amount": 14}, Enchantments: [{id: "minecraft:bane_of_arthropods", lvl: 5s}, {id: "minecraft:fire_aspect", lvl: 2s}, {id: "minecraft:knockback", lvl: 2s}, {id: "minecraft:looting", lvl: 3s}, {id: "minecraft:sharpness", lvl: 5s}, {id: "minecraft:silk_touch", lvl: 1s}, {id: "minecraft:smite", lvl: 5s}, {id: "minecraft:sweeping", lvl: 3s}], Damage: 0, display: {Lore: []}}, Count: 1b}
22:19:50.351 [CHAT] ql0u0lp has the following entity data: {id: "minecraft:netherite_sword", tag: {PublicBukkitValues: {"reforges:reforge": "sharp", "reforges:reforge_amount": 1}, Enchantments: [{id: "minecraft:bane_of_arthropods", lvl: 5s}, {id: "minecraft:fire_aspect", lvl: 2s}, {id: "minecraft:knockback", lvl: 2s}, {id: "minecraft:looting", lvl: 3s}, {id: "minecraft:sharpness", lvl: 5s}, {id: "minecraft:silk_touch", lvl: 1s}, {id: "minecraft:smite", lvl: 5s}, {id: "minecraft:sweeping", lvl: 3s}], Damage: 0, display: {Name: '{"italic":false,"extra":[{"italic":false,"extra":[{"translate":"item.minecraft.netherite_sword"}],"text":""}],"text":""}', Lore: []}}, Count: 1b}

Screenshot of log with annotation

Server Information (please complete the following information):

• Version:
  Current: git-Purpur-1718 (MC: 1.19)*
  Previous: git-Purpur-1699 (MC: 1.19)

• You are 1 version(s) behind
  Download the new version at: https://purpurmc.org/downloads

• Version of plugin and eco (/ver eco, /ver <plugin>)
  eco version 6.37.3
  Reforges version 5.25.2

Additional context
Reported on discord when first discovered and advised to open report here.

cant translate message when not enough money

Please report bugs on the discord!

When it's not enough money for reforge and player clicking to the reforge btn, they have this message:

I can't find where i can translate it...
Join by clicking here

Custom Reforged Items

Is your feature request related to a problem? Please describe.
There's a ton of things you can do with the plugin right now, but if I wanted to make, for example, 2 sets of armor, one non reforged and another reforged, I can't use this plugin to give the reforged item for the non reforgd one.

Describe the solution you'd like
You could add a feature that'd let you give a specific item as result of the reforge of a specific item. For example, a netherrite sword in exchange for a diamond sword. You could set this up in your config or maybe an ingame editor.

Describe alternatives you've considered
Changin the plugin.

add_stat effect not working with aurelium skills

Hello

I made a reforge that gives you 10 strength when applied to any diamond item, but when i held my reforged diamond sword, it gave me an error

[17:39:48 WARN]: [Reforges] Task #33126 for Reforges v4.11.2 generated an exception
java.lang.IllegalArgumentException: No enum constant com.archyx.aureliumskills.stats.Stats.strength
at java.lang.Enum.valueOf(Enum.java:273) ~[?:?]
at com.archyx.aureliumskills.stats.Stats.valueOf(Stats.java:8) ~[AureliumSkills-Beta1.2.7.jar:?]
at com.willfp.reforges.libreforge.integrations.aureliumskills.EffectAddStat.handleEnable(EffectAddStat.kt:18) ~[Reforges v4.11.2.jar:?]
at com.willfp.reforges.libreforge.effects.Effect.enableForPlayer(Effect.kt:101) ~[Reforges v4.11.2.jar:?]
at com.willfp.reforges.libreforge.LibReforgeUtils.updateEffects(LibReforge.kt:177) ~[Reforges v4.11.2.jar:?]
at com.willfp.reforges.reforges.util.ReforgeEnableListeners.refreshPlayer(ReforgeEnableListeners.java:139) ~[Reforges v4.11.2.jar:?]
at com.willfp.reforges.reforges.util.ReforgeEnableListeners.lambda$onChangeSlot$0(ReforgeEnableListeners.java:101) ~[Reforges v4.11.2.jar:?]
at org.bukkit.craftbukkit.v1_17_R1.scheduler.CraftTask.run(CraftTask.java:101) ~[patched_1.17.1.jar:git-Paper-400]
at org.bukkit.craftbukkit.v1_17_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:483) ~[patched_1.17.1.jar:git-Paper-400]
at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1567) ~[patched_1.17.1.jar:git-Paper-400]
at net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:490) ~[patched_1.17.1.jar:git-Paper-400]
at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1483) ~[patched_1.17.1.jar:git-Paper-400]
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1282) ~[patched_1.17.1.jar:git-Paper-400]
at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:319) ~[patched_1.17.1.jar:git-Paper-400]
at java.lang.Thread.run(Thread.java:833) ~[?:?]

Im playing on 1.17.1 and im using Paper 1.17.1 to run my server, im also using Java 17

Can you help me please? Thanks

add compatible with aureliumskill

Add effects compatible with AureliumSkill

Be able to add life points
Be able to add mana
Be able to add strength

Strong Reforge decreasing item's damage?

For example Netherite Swords with Strong Reforge deals 1 damage per hit, just like using bare hands. I don't know if it is just me.

Plugin kicks me update 6.49.0

When I am trying to use ANY commands on my PurPur 1.20.2 server, its kicks me with this error:

Console:

Reforges GUI Internal Error when used with UnifiedMetrics

Describe the bug
The plugin doesn't activate on startup when used in parallel with UnifiedMetrics, possibly because of Kotlin. This causes the GUI of the Reforge plugin to entirely bug out on startup.

To Reproduce
Steps to reproduce the behavior:

1. Download UnifiedMetrics, https://github.com/Cubxity/UnifiedMetrics/releases
2. Download Reforges + Eco
3. Put them all into the /plugins folder and startup.
4. Reforges GUI errors itself out.

Expected behavior
Reforges should open the menu when doing /reforge

Screenshots
Error Log: https://hastebin.de/iqobawoxit.md
Startup Logs (Libraries): https://hastebin.de/fijuvawufi.less

Server Information (please complete the following information):

• Version: Pufferfish Build #40
• Version of plugin and eco: 4.41.0 | 6.24.0

Display lore gui

Describe the bug
The description "This item can be reforged" appears in the plugin command panel.

To Reproduce
Steps to reproduce the behavior:

1. Dl Command Panel : https://www.spigotmc.org/resources/command-panels-custom-guis.67788/
2. Open gui
3. See error

Expected behavior
Fix the bug

Screenshots
If applicable, add screenshots to help explain your problem.

Server Information (please complete the following information):

• Version: git-Purpur-1623 (1.18.2)
• Version of plugin and eco : pl: 4.71.3 eco: 6.35.7