Giter Site home page Giter Site logo

Comments (8)

0xabdulkhalid avatar 0xabdulkhalid commented on July 17, 2024

Hey there @avinashkranjan 👋🏻

Please make sure to assign this issue to me asap to make the work done!

Thank you.

from friday.

avinashkranjan avatar avinashkranjan commented on July 17, 2024

Go Ahead

from friday.

0xabdulkhalid avatar 0xabdulkhalid commented on July 17, 2024

@avinashkranjan a person has created a PR for this issue which i was assigned by you without your permisson.

Kindly close his PR and merge my PR to fix this issue.

Thank you for your attention!

from friday.

suman-somu avatar suman-somu commented on July 17, 2024

The issue is not fixed by your PR. The light mode is not working.
Also, the method you used to handle dynamic handling of images is old. I have used the new format syntax for that.

from friday.

0xabdulkhalid avatar 0xabdulkhalid commented on July 17, 2024

Bro, the light mode is finely working then how can i show the screenshot ?

First of all as a fellow contributor please make sure to follow ethics while contributing.

How can you open a PR without informing the Project Admin or the one who created this ?

Doing these types of stuffs is strictly against contributing guidelines.

Hope you understood, let the Project Admin @avinashkranjan handle this problem.

from friday.

suman-somu avatar suman-somu commented on July 17, 2024

First, I don't know how are you saying it's working fine when it's clearly not.
image

Secondly, it was my mistake that I overlooked your commitment and started to work on it. I realised it after making the PR.
After which, I didn't even mentioned once to merge my PR after that.

from friday.

0xabdulkhalid avatar 0xabdulkhalid commented on July 17, 2024

@suman-somu How can you see the image if the page still not properly loaded yet 🤦‍♂️, the mistake is with your network not my code.

image

Here's how it looks, just view it from view file from this PR.

image

I have already told you that you are not permitted to open a PR for which not assigned to you yet, You doesn't follow contributing guidelines here.

Please close that, that's all i can say.

Otherwise it will be closed by Project Admin.

from friday.

suman-somu avatar suman-somu commented on July 17, 2024

You are using old syntax for image insertion, which is why it's just never loads or takes much time.
https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#specifying-the-theme-an-image-is-shown-to
The mistake is not with my network but with your code itself. And not just arguing over guidelines maybe you should have fixed it when I mentioned it earlier.
Also, maintainers know the guidelines you are trying to specify in every message. The guidelines are meant to be for the betterment of the project and the PA will do same.

from friday.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.