aws-samples/amazon-eks-refarch-cloudformation

Reference architecture of Amazon EKS cloudformation templates and AWS CDK samples

amazon-eks-refarch-cloudformation's Issues

auto create node label NVIDIAGPU=1 for GPU instances

Error running npm run build

Hello there,

I'm getting the following error message when trying to run the build script. Any suggestions would be welcome!

tsc

node_modules/@types/node/index.d.ts:97:11 - error TS2300: Duplicate identifier 'IteratorResult'.

97 interface IteratorResult { }
~~~~~~~~~~~~~~

node_modules/typescript/lib/lib.es2015.iterable.d.ts:41:6
41 type IteratorResult<T, TReturn = any> = IteratorYieldResult | IteratorReturnResult;
~~~~~~~~~~~~~~
'IteratorResult' was also declared here.

node_modules/typescript/lib/lib.es2015.iterable.d.ts:41:6 - error TS2300: Duplicate identifier 'IteratorResult'.

41 type IteratorResult<T, TReturn = any> = IteratorYieldResult | IteratorReturnResult;
~~~~~~~~~~~~~~

node_modules/@types/node/index.d.ts:97:11
97 interface IteratorResult { }
~~~~~~~~~~~~~~
'IteratorResult' was also declared here.

Found 2 errors.

Issue with eks-auth-update-hook

Hello,

I am trying to working with the repo but I am facing some issue, there is some basic one related to the version of the cluster, and it was easy to update by changing the version from 1.10,1.11,1.12,1.23 to 1.19, 1.20, 1.21, 1.22

When I am doing make to create the cluster, the main cloud formation failed, I can see the nested one :
CL, NG are ok but then I have this issue coming on the third nested formation AMI)

Transform AWS::Serverless-2016-10-31 failed with: Invalid Serverless Application Specification document. Number of errors found: 1. Resource with id [ConfigMapUpdate] is invalid. Application with id arn:aws:serverlessrepo:us-east-1:XXXXXXXX:applications/eks-auth-update-hook could not be found.

Any idea what I am missing ?

Thanks

instlal kubectl 1.14 as default

https://docs.aws.amazon.com/eks/latest/userguide/install-kubectl.html

Upgrade fluentd + cloudwatch-agent

Bumped versions of images fluentd and cloudwatch-agent to latest version.

• fluent/fluentd-kubernetes-daemonset:v1.9.2-debian-cloudwatch-1.0
• amazon/cloudwatch-agent:latest

Also changed the cloudwatch-agent from fixed to latest to keep the pattern of all the other services.

support passing ExtraNodeLabels

e.g

extralabel01=yes,extralabel02=1

or just

NVIDIAGPU=1

Getting EKS AMI from SSM Paramater Store

Amazon EKS support getting AMI from ssm parameter store now.

https://aws.amazon.com/tw/about-aws/whats-new/2019/09/amazon-eks-provides-eks-optimized-ami-metadata-via-ssm-parameters/

aws/containers-roadmap#231

Cloudformation template is outdated

I wanted to let know that your Cloudformation script is outdated. Specifically, the ClusterVersion template parameter is what causes the stack to fail to build:

AllowedValues:
      - "1.10"
      - "1.11"
      - "1.12"
      - "1.13"
      - "latest"

Currently 1.19 to 1.21 is supported, and "latest" is apparently not a valid kubernetes version (as per EKS). In addition, there is a logical error after you get to build the cluster with a supported version:

AWS::EKS::Cluster without 'Version' property will not create latest cluster version

For example, the following cfn template will create 1.12 in ap-northeast-1

AWSTemplateFormatVersion: 2010-09-09

Resources:
  EKSCluster:
    Type: "AWS::EKS::Cluster"
    Properties:
      Name: demo
      ResourcesVpcConfig:
        SecurityGroupIds: 
          - sg-0153bc41936cad87d
        SubnetIds: 
            - subnet-050196ad9cabc770d
            - subnet-01dc57b9cb22345b4
            - subnet-00a56b14600908367
      RoleArn: arn:aws:iam::903779448426:role/EKS-CDK-demo2-eksdemocdk2ClusterRoleFC35564C-CNS930B6OMG3

However, in EKS console 1.13 should be the current latest version.

And according to the document, the latest version available should be used.

support cdk 1.81.0 with patch

let's support 1.81.0 with the patch aws/aws-cdk#12291

support ExtraSecurityGroups

amazon-eks-refarch-cloudformation/cloudformation/nodegroup.yaml

Lines 490 to 495 in 93bfb86

	Groups:
	!If
	- CreateNewNodeSG
	-
	- !Ref NodeSecurityGroup
	- !Split [ ",", !Ref ExistingNodeSecurityGroups ]

support CreateNewNodeSG + ExtraSecurityGroups