Extension install scripts fail with empty variables

[aws-samples]

Extension install scripts fail with empty variables

[athewsey]

I agree that, for the majority of our scripts that don't take any params from the parent shell, quoting the heredoc delimiter is more readable/less overhead than escaping each use of a variable :-)

Will raise a PR imminently to have a crack at the rest and revert the extension installation ones to quoted delimiter

[athewsey]

I just did a quick check and think this will also affect:

• install-conda-package-all-environments
• install-conda-package-single-environment
• install-pip-package-all-environments
• install-pip-package-single-environment
• install-server-extension
• persistent-conda-ebs
• set-git-config

[mckev-amazon]

Hi athewsey,

Thanks for submitting this issue. Indeed, it would appear that we need to quote the "heredoc delimiter" with quotes in order to disable variable expansion entirely inside of the heredoc. Escaping $ with $ would also work as well (no strong preference to either).

Feel free to submit a PR for the others, otherwise we will fix this as soon as possible.

[mckev-amazon]

Awesome, thank you very much!