script hangs on collecting Docker information

[aws]

script hangs on collecting Docker information

[WillHoule]

Hey there!

For that step in the collection, the script uses the builtin Docker commands to gather the information. So this seems like the Docker daemon itself was hanging when receiving commands. If you manually run something like docker info or docker ps from the instance, are you seeing a delayed/no response?

Regardless, it'd probably be a good idea for a timeout of sorts to be added for some of the collection steps.

[UnaKarlsen]

This sort of issue is usually as a result of the Docker Daemon being unresponsive. The Docker client just never seems to time out when requesting info from the daemon.

A possible fix for this would be to ping the Docker API to check whether it is responding first.
curl -S -m 60 --unix-socket /var/run/docker.sock http://localhost/_ping
Doing this lets you set a timeout. If the API does not respond successfully, there is no point in running any of the Docker commands as they will just hang. This can be reported to the user and the rest of the log collection can continue as per normal.

I'll try to send a PR with this modification in the next day or 2.