Comments (2)
I think makes more sense if we add the datetime variable in the pack routine since the try_set_instance_collectdir routine is intended to discover the instance ID only:
${tar_bin} -cvzf "$curdir/$pack_name-$datetime".tgz "$collectdir" > /dev/null 2>&1
Additionally, we have to declare the variable here as follows:
# datetime is the date and time when the script was executed used in pack()
datetime=`date +%Y%m%d%H%M`
# pack_name is the name of the resulting tarball. This will generally
# be collect-i-fffffffffffffffff-ddddddddtttt, where i-ffffffffffffffffff is the
# instance id and ddddddddtttt is the date and time.
pack_name="collect"
Also remember to update the README usage section.
On the other hand, it seems the variable dstdir is not declared, let's add it here:
# dstdir is the destination where the logs collected are placed.
dstdir='' # defined in several routines
from amazon-ecs-logs-collector.
Fixed by @rohanmangal - thanks for the contribution!
from amazon-ecs-logs-collector.
Related Issues (17)
- "wget" didn't come on my Amazon Linux ECS box HOT 2
- script hangs on collecting Docker information HOT 2
- Change variable infodir to use instanceId rather than the word collect
- Creates wrong archive type HOT 3
- Improve the Usage Documentation HOT 1
- Collect and probe based on environment, not on detected system HOT 1
- Detect required tools and optionally install if missing HOT 1
- Unquoted paths could result in incorrect output HOT 1
- Feature Request: dmesg logs Human Readable timestamps HOT 2
- Update log collector to work with AL2 (and other systemd based things) HOT 2
- Script didnt generate tarball.. HOT 2
- collect lspci output HOT 1
- Consider collecting aws-appmesh.log HOT 1
- log collection can wait indefinitely
- [Feature Request] Automatically mask credential information when running the ECS Logs Collector
- [Feature Request] Collect GPU Info for GPU Container Instances HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from amazon-ecs-logs-collector.