Giter Site home page Giter Site logo

Comments (2)

fjromerom avatar fjromerom commented on July 24, 2024

I think makes more sense if we add the datetime variable in the pack routine since the try_set_instance_collectdir routine is intended to discover the instance ID only:

${tar_bin} -cvzf "$curdir/$pack_name-$datetime".tgz "$collectdir" > /dev/null 2>&1

Additionally, we have to declare the variable here as follows:

# datetime is the date and time when the script was executed used in pack()
datetime=`date +%Y%m%d%H%M`
# pack_name is the name of the resulting tarball. This will generally
# be collect-i-fffffffffffffffff-ddddddddtttt, where i-ffffffffffffffffff is the
# instance id and ddddddddtttt is the date and time.
pack_name="collect"

Also remember to update the README usage section.

On the other hand, it seems the variable dstdir is not declared, let's add it here:

# dstdir is the destination where the logs collected are placed.
dstdir=''  # defined in several routines

from amazon-ecs-logs-collector.

Realmonia avatar Realmonia commented on July 24, 2024

Fixed by @rohanmangal - thanks for the contribution!

from amazon-ecs-logs-collector.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.