Giter Site home page Giter Site logo

mitsy's People

Contributors

awsdert avatar

Stargazers

 avatar  avatar

Watchers

 avatar  avatar

mitsy's Issues

Unit tests do not compile

I attempted to update unit_tests.c so that it will compile using the latest code structure (filenames etc), but gave up in the attempt: too many errors. I could probably spend a lot of time and get it to work but maybe it's better to rewrite the file from scratch (?) to more accurately test the current state of the project. Not sure...

Confusing code

file mcc_get.c (line 55 for current master head; c7625b1)

	if ( size ) {
		if ( addr )	addr = realloc( addr, size );
		else addr = malloc( size );

There is no need for this; i.e. if addr is NULL then realloc(addr, size) is the same as realloc(NULL, size) which is perfectly fine and safe (if it's NULL realloc behaves the same as malloc(size)). So, although you'd need to add a temp variable in case realloc() fails I think that overall it would be more readable.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.