The ex338's discuss from axelclark

League owners are emailed when new waivers are submitted

League owners are emailed when new waiver is submitted.

Owners can submit trades

After a trade has been negotiated, an owner can submit the trade to the league for approval.

Rules updated for waivers process

Update the rules to better explain the waiver process.

League owners are emailed when waivers are processed

When waivers are processed as successful or unsuccessful, the owners are emailed.

Validate an owner can't submit multiple player on same roster position

When an owner updates the roster positions, a validation is performed to ensure two players aren't on the same position.

Owners can update the player to drop

Owners should be able to update the player to drop according to the waiver rules.

Roster Positions that are "dropped" or "traded" are treated as deleted

Once a Roster Position is deleted by having its status changed to "traded" or "released", it is handled that way across the site

does not display in FantasyTeam show & index
available in Draft and Waiver select options

An add only waiver is invalid if there is not an open position

According to the rules, a waiver must include a drop unless there is an open position on the team.

Error if owner submits blank new waiver form

There is an error if on the new waiver form, the user submits blank for both add and drop player.

Player to add listed in waiver email subject

The player to add is listed in the waiver email subject so it's easier to scan

Refactor waiver controller

Move business logic out of the controller.

Errors on fields don't use normal text

When a form field has an error, the description stands out (i.e. red or bold)

Dates are associated with championships rather than sports leagues

Some sports leagues have multiple championships, so the dates should be associated with a championship rather than the overall league.

Update aliases in mix.exs

Mix test --exclude integration
Migrate with rollback

RosterPosition is effective after the event if waiver is submitted after event deadline

If a new waiver is submitted after an event deadline (before the overall sport deadline), the rosterposition effective date is after the event.

Clarify waivers can't be cancelled is existing rule

Update highlighting to clarify the rule that waivers can't be updated is an existing rule and not made due to change to using the site.

League owners are emailed when a new waiver is submitted

When an owner submits a new waiver, the league is emailed.

Adjust rememberable time period

Update the remember me configuration to expire the cookie after 30 days.

Owners can view key dates for each Sports League

New waiver cannot be submitted after waiting period ends

When an owner submits a new waiver for a team that already has a pending waiver, the new waiver is not valid if it is submitted after the waiver wait period ends. Application should validate the process_at datetime is in the future when a new waiver is submitted.

def validate_wait_period_open(waiver_changeset) do
  process_at = get_change(waiver_changeset, :process_at)
  now        = Ecto.DateTime.utc

  validate_wait_period_open(waiver_changeset, process_at, now)
end

defp validate_wait_period_open(waiver_changeset, process_at, now), when process_at <= now, do: waiver_changeset

defp wait_period_open?(waiver_changeset, process_at, now), when process_at > now do
  add_error(waiver_changeset, :add_fantasy_player_id, "Existing waiver and wait period has already ended.")
end

Team name can't be over 16 characters

Limit team names to 16 characters for spacing and formatting purposes.

List overall pick number on the draft page

Feature request from gavin.johnson

https://the338challenge.slack.com/archives/general/p1474296554000002

Waiver table labels are clear and order makes sense

Waiver table column headings should be more clear instead of "Effective Date".
Consider reversing the order of the pending waivers so the waivers to process first are on top.

Winnings, winnings paid, and dues are listed on the website

The winnings to date during the season, the amount of winnings paid, and the dues paid is listed for each team so the commissioner doesn't have to keep a separate spreadsheet and there is transparency with the owners.

admin site shows all fields for waiver and roster_position

Update edit and show

Waiver: process_at
RosterPosition: status, released_at

RosterPosition is created when a waiver is successful

When an admin approves a waiver claim, the roster position is created automatically

When a player is dropped they still show on the RosterPosition update form

When a player is dropped after a successful waiver claim, the player no longer shows on the fantasy team, except when the owner goes to the roster position update form.

Add commish notes to fantasy team

Owners can update payment preferences for the team.

Drop only waivers are processed immediately

When an owner submits a waiver with only a player to drop, the waiver is processed immediately with the waiver status updated and the roster_position status updated.

A new waiver is not valid if submitted after the sports league waiver deadline

When an owner submits a new waiver, the new waiver is not valid if it is submitted after the waiver deadline for the sports league/championship. Application should validate the championship waiver deadline is in the future when a new waiver is submitted.

Write tests for all 2nd level functions
Move repo transaction to waiver module
Pass errors for repo actions within multis to multi
get_existing_waiver_data: don't pass nil && get fantasy league id from waiver struct
Move three_days_from_now to CalendarAssistant
league_teams_count: use FantasyLeague.by_league
update_league_waiver_position: move query to FantasyTeam module

Add column to track when RosterPosition is deleted

When a player is dropped or traded, the RosterPosition is updated in a column rather than deleted from the database.

Dues link is displayed on the main page

The link to pay team dues should be listed on the site.

axelclark / ex338 Goto Github PK

ex338's Issues

Recommend Projects

Recommend Topics

Recommend Org