ay2324s1-cs2103t-w16-1 / tp Goto Github PK

This project forked from nus-cs2103-ay2324s1/tp

License: MIT License

Java 98.60% CSS 1.40%

tp's Introduction

KeepInTouch

KeepInTouch is a Desktop application developed for jobseekers. It is meant to help them track connections in their professional network, along with events related to their professional development.

For a more detailed documentation of this project, please visit our product website.

Acknowledgement

This project is based on the AddressBook-Level3 project created by the SE-EDU initiative.

tp's People

Contributors

Forkers

josepholim andrewjanong zekone larrywang0701 nixx162

tp's Issues

[PE-D][Tester A] Viewing help issue

According to the use guide, help should "Shows a list of commands with the functionalities." But perhaps the functionalities portion has been missed out. So the behaviour differs from the User guide.

Severity is medium as the help does not let me know what the use of each command is.

Labels: type.FunctionalityBug severity.Medium
original: Gabriel4357/ped#1

[PE-D][Tester C] Help command in UG but not actually available

In the UG, there is mention of a help command. But when I enter help, I get an error message. Not sure if the problem is there is no help command (then the UG should be updated), or the help command is not working as expected. I will mark it as documentation bug, cus I think you probably just didnt remove it from the UG

Labels: type.DocumentationBug severity.Medium
original: chuababyy/ped#1

Enable Assertions in build.gradle

List notes feature

[PE-D][Tester D] Clear is in jar file, not in UG

Clear command exists in jar file, not in UG

Labels: severity.Low type.DocumentationBug
original: itsNatTan/ped#6

Filter Tag Commands

Features for these user stories:

As a user, I want to view contacts with specific tags, reflect in the UI

Add DG for Edit Tags

Adapt User Stories

Add user story into the DG

Add tag-related features

Features to be added:

Add tag to contact
Delete tag from contact

[PE-D][Tester C] Phone number has no validation

Might want to consider having a phone number check to ensure it is 8 digits etc.

Labels: type.FeatureFlaw severity.VeryLow
original: chuababyy/ped#5

[PE-D][Tester D] Links in TOC of UG unclickable

All these links do not direct me to my desired location. The URL is changed, but it does not bring me there

Labels: severity.Low type.DocumentationBug
original: itsNatTan/ped#1

Adapt User Guide

[PE-D][Tester D] Missing out part of the name causes find command to fail

Unsure if this is a bug or a feature, but find Ale, does not find Alex. Help tool mentions that as long as it contains the keywords it will find it. If this is intended, suggest to change tooltip to "matches any keywords" or some sort, to give a better understanding.

However, I believe that find should not match word by word. What if I want to find all contacts starting with "a". I believe that this will boost the functionality of the find command.

Labels: type.FeatureFlaw severity.Medium
original: itsNatTan/ped#9

Adapt DG: Use Cases

Give use cases (textual form) for a few representative user stories that need multiple steps to complete.
e.g. Adding a tag to a person (assume the user needs to find the person first)

Update tag related user story and use case in DG

[PE-D][Tester D] Same as help add, help delete is missing "delete tag"

Delete tag is in UG, but not in the help function.

Labels: severity.Low type.FeatureFlaw
original: itsNatTan/ped#5

[PE-D][Tester D] Edit function available in the jar file, but not recorded in the UG

Edit command exists in the jar file, but is not found in the UG.

Labels: severity.Low type.DocumentationBug
original: itsNatTan/ped#4

[PE-D][Tester D] Add tag function does not work at all

After typing add tag -id 1 -t Frontend, contact at id 1, Alex Yeoh did not get a new tag, even after refreshing the list

I tried other ids and other tags but all failed.

Labels: severity.High type.FunctionalityBug
original: itsNatTan/ped#10

Update README

Adapt Product Scope

Adapt product scope fro AB3 to our project

Add more features related to time on event commands

view all events in chronological order
view events within a specific date range
notify user if two events are clashing

Add event feature

Add event feature support - commands add event, list events and delete event

NullPointerException in event-related logic and ghost events after deleting contacts that have events

Allowing null in EventTime.time lead to NullPointerException in various time-related logic

Ghost event: the following commands:

add event -id 1 -en sdfgs -st 2012-10-10
delete contact 1
add event -id 1 -en sdfgs -st 2012-10-10

will fail due to not removing the event associated to the contact from the global list after deleting the contact

Adapt DG: Non-functional requirements

Define non-functional requirements for the project. Many of the given project constraints can be considered NFRs.

[PE-D][Tester D] UG does not contained promised picture of GUI

"( A GUI similar to the below should appear in a few seconds. Note how the app contains some sample data.)". However, no GUI was found

Labels: severity.VeryLow type.DocumentationBug
original: itsNatTan/ped#2

Fix bug where empty fields are accepted in note commands

[PE-D][Tester E] Extraneous parameters not being ignored

Description

In the user guide, it is stated that extraneous parameters will be ignored. An example mentioned was that help 123 will be interpreted as help.

As such, it is expected that they would have the same output.

Steps to Reproduce

Launch KeepInTouch
Enter command help
Enter command help 123

Expected Behaviour

Output from steps 2 and 3 would be the same.

Actual Behaviour

Output from step 2 is the expected help output, whereas the output from step 3 is "Unknown Command"

Ideas

help does in fact take in additional, optional parameters and shouldn't be listed as an example in that particular section of the user guide.
Alternatively, help can perform some checks on extraneous parameters.

Labels: severity.VeryLow type.DocumentationBug
original: nathanielcalimag/ped#1

Tutorial: tracing code

Support duplicate person names

The original AB3 does not support adding person with duplicate person names:

tp/src/main/java/seedu/address/logic/commands/AddPersonCommand.java

Line 54 in a544f9a

throw new CommandException(MESSAGE_DUPLICATE_PERSON);

tp/src/main/java/seedu/address/model/person/Person.java

Line 148 in a544f9a

public boolean isSamePerson(Person otherPerson) {

But in KeepInTouch since we are using index to identify persons, so duplicate person names should be supported.

Improve help command

[PE-D][Tester A] Potential UI bug

If the name is too long, is it supposed to wrap around so that it can be seen?

Labels: severity.Low type.FunctionalityBug
original: Gabriel4357/ped#5

[PE-D][Tester C] Cannot add tag to contact

Is there a limit to the number of tags? It is not stated anywhere.

Using the default info as a reference. By default there is a person called bernice yu with 2 tags already loaded.

When I try to add more tags to bernice yu, i get this success notification: New tags added: [new]

But the contact card does not have the new tags immediately.

I tried it out more and I see that only if i change the view (list contact -t new) then i use list contact again then i can see the new tags.

If i use list contact alone, the new tags dont show up

Labels: type.FunctionalityBug severity.High
original: chuababyy/ped#3

[PE-D][Tester B] Behavior of find command differs from UG

In UG, it is mentioned that the keyword in find command is case sensitive. But, when I use find command with the keyword "Person" it returns results with name that contains "Person" and "person", which means the find command is case insensitive.

Personally, I think name should be case-insensitive. But developer team should decide on one of them and resolve the conflict.

Labels: severity.High type.FunctionalityBug
original: NereusWB922/ped#4

[PE-D][Tester A] List contact error message

Perhaps list contact could give out some error messages. In this case, I called list contact without using -t for awhile before realising I had to use the prefix -t.
And calling list contact without the prefix but with the tag (e.g list contact friends instead of list contact -t friends) actually shows the whole list which made me a little confused at the start. Maybe an error message when no prefixes are given would be good

Screenshot shows what happens when I call list contact friends with no -t

Labels: severity.Low type.FunctionalityBug
original: Gabriel4357/ped#2

[PE-D][Tester A] Name bug

Not sure if intentional but are names supposed to accept numbers as accepted values?

Labels: severity.Low type.FunctionalityBug
original: Gabriel4357/ped#4

[PE-D][Tester B] Unmatched command list

UG:

Application:

edit and clear command is not listed in UG.

Labels: severity.Medium type.DocumentationBug
original: NereusWB922/ped#3

[PE-D][Tester D] UG states that find command should be case sensitive, but in actual implementation is not

Either a Documentation bug or a FeatureFlaw bug, depends on what was actually intended (Not sure). But find bob will find Bob.

Labels: severity.Low type.FeatureFlaw
original: itsNatTan/ped#8

Fix assertion for duplicate contacts

Change the UniquePersonList to handle duplicate contacts with all the identifiers the same

Add contact features

Implement features for contacts such as add contact, delete contact, and list contact.

[PE-D][Tester D] Help command for add function missing add tag

As seen in the picture above, after typing help add, only add event, add note and add contact are shown.

However, on UG, there is an add tag function that is not included when typing help add into command box.

Labels: severity.Low type.FeatureFlaw
original: itsNatTan/ped#3

if i use delete tag -id 3 -t f to delete a tag f which does not exist i still a success message Successfully deleted tags: [f]

You should instead be displaying some sort of error to show that the tag does not exist

Labels: type.FunctionalityBug severity.High
original: chuababyy/ped#4