Comments (9)
If added, need to make this configurable too:
server/game/DungeonFinding/LFGMgr.h:40: LFG_GROUP_KICK_VOTES_NEEDED = 3
And do it like that:
LFG_GROUP_KICK_VOTES_NEEDED = (CONFIG_LFG_VOTE_KICK_REQUIRED_NUMBER_OF_PLAYERS) ? CONFIG_LFG_VOTE_KICK_REQUIRED_NUMBER_OF_PLAYERS; ceil(CONFIG_GROUP_MAX_PLAYERS_SIZE)`
EDIT: and also it must not work if the group size = 2, else only 1 vote can kick the other player
from mod-solo-lfg.
+1
from mod-solo-lfg.
WIP 💀
from mod-solo-lfg.
Another bunch of suggestions:
- name is kinda misleading "solo-lfg" as we can "duo-lfg" "trio-lfg" etc xD, we need to find a better name for the config options :P (i'll help ofc)
- command to toggle on/off (depending on the actual state of the feature. If server is configured by default to be active, then first command usage will toggle it off for the player in question) per player (aka current group's leader, so it works for an incomplete group too). Why? that way, when the system is set to off, a solo (or duo etc...) can join the LFG system and find random players to help them
from mod-solo-lfg.
I would call it lfg-insta-pop
.
Configuration proposal:
LFG.insta.pop.enable
- enable insta-pop on serverLFG.insta.pop.solo.enable
- enable solo (no group) insta-pop on serverLFG.insta.pop.solo.command.enable
- enable player.lfg insta pop solo on|off
command to toggle insta pop.LFG.insta.pop.solo.command.announce
- announce state of.lfg insta pop solo on|off
LFG.insta.pop.party.enable
- enable party insta-pop on serverLFG.insta.pop.party.command.enable
- enable party leader.lfg insta pop party on|off
command to toggle insta pop.LFG.insta.pop.party.command.announce
- announce state of.lfg insta pop party on|off
LFG.insta.pop.party.min.group.size
- set limit 2,3,4
LBRS/UBRS not taken into consideration yet as they are special 10-man dungeons.
from mod-solo-lfg.
Better names:
lfg-instapop
LFG.instapop.x.x
Questions:
why the distinction between solo and party? (i can't think well atm, maybe i don't see something that could be useful :P)
what is announce state for? what would it announce?
and how do lbrs/ubrs fit in the Random Dungeon Finder tool?
from mod-solo-lfg.
Because as admin
you can choose to enable instapop for solo and party or just solo or just party. Depends how crazy admin
is but we give him all he need.
Yes, i would remove announcer and make it by default to announce the state when you use .lfg instapop solo on|off
.
I will analyze lbrs/ubrs and come back with an answer. I don't really know.
from mod-solo-lfg.
dunno if useful to tell the player, maybe it is, okay for the rest
from mod-solo-lfg.
Since the issue is approximately 3 years old, I will close it, and if necessary, we will reopen it. But I want to ensure that the open issues, are currently bugs or improvements that we should apply to the module today. So if we have to reopen the issue, it is reopened, or a new updated issue is created, with all the updated information, so that we can correct the error or see the possibility of implementing what was discussed here.
from mod-solo-lfg.
Related Issues (20)
- Issue applying patch HOT 2
- Patch broken since last Update/Commit of azerothcore HOT 6
- replace patch implementing some hooks on AC HOT 3
- On death you cannot return to the instance to get your body HOT 9
- Failed to compile in VS2019 HOT 4
- Update to lates Core and fix #16 [30$]
- Azerothcore PR #7008 breaks the patch provided.
- Unable to apply patch to AC core files - patch failed HOT 1
- Docker - Error building acore HOT 1
- Error while Applying the LFG-Solo.patch HOT 1
- solo-lfg incompatible with AzerothCore 4.0 HOT 4
- Compile fail HOT 1
- Cant apply and build with recent AC HOT 2
- Money not being looted. HOT 1
- Bug: Wrong dungeon type 0 for dungeon 0 HOT 5
- Docker build fails HOT 1
- Bug: Getting stuck in a group. HOT 8
- Bug: using Dungeon Finder (LFG) solo HOT 1
- conflict HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mod-solo-lfg.