azu/get-github-pr-review-comments

Get PR review comments from command line.

get-github-pr-review-comments's Issues

Using token in the url as a get parameter is deprecated

Hi

I used the tool today and it works perfectly. However, right after I received an email from Github:

On January 26th, 2021 at 15:52 (UTC) your personal access token (All access) using NodeJS HTTP Client was used as part of a query parameter to access an endpoint through the GitHub API:

https://api.github.com/search/issues

Please use the Authorization HTTP header instead, as using the access_token query parameter is deprecated. If this token is being used by an app you don't have control over, be aware that it may stop working as a result of this deprecation.

Depending on your API usage, we'll be sending you this email reminder on a monthly basis for each token and User-Agent used in API calls made on your behalf.
Just one URL that was accessed with a token and User-Agent combination will be listed in the email reminder, not all.

Visit https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param for more information about suggested workarounds and removal dates.

TypeError: Cannot read property 'data' of undefined

Thanks for the awesome library. It really improves my workflow when combined with iTerm Command click to open straight in my text editor.

Also sorry for the minimal bug report, but I get this error occasionally. (Not sure of the cause)
I have a script I name comments which has the following hacky bash in it to grab the current repo name and SHA.

get-github-pr-review-comments --repo '`cat .git/config | grep -o "[^\ ]*\.git" | grep -o ":.*\." | sed -e 's/://'  | sed -e "s/\.//"`' --projectRoot .  `git rev-parse HEAD`

I.e. something like:

get-github-pr-review-comments --repo 'azu/get-github-pr-review-comments' --projectRoot . e452b8ab4a09ab42d5dee1ba96cb34bc2f676822

Error output

Cannot read property 'data' of undefined TypeError: Cannot read property 'data' of undefined
    at defaultFormatter (/usr/local/lib/node_modules/get-github-pr-review-comments/lib/formatter.js:54:31)
    at /usr/local/lib/node_modules/get-github-pr-review-comments/lib/cli.js:59:16
    at processTicksAndRejections (internal/process/task_queues.js:85:5)

It doesn't always happen though, so not sure of the cause. Apologies I haven't had a chance to debug the issue.

Loop through the pages to get all the comments

If I am right, the script does not override the "per_page" argument and does not loop through all the comments so we actually only get the first 30 comments of a pull request.

It would be great that the script does loop over all the comments.

How to know that comment is resolved?

GitHub collapse comment which is resolved.
How to get the information?