Giter Site home page Giter Site logo

Comments (5)

sandeepmistry avatar sandeepmistry commented on August 22, 2024

Hi @yaweiw,

We can definitely add a NULL check for prevent it crashing. Could you please share an example sketch and steps to reproduce the issue. I'm curious as to how you are encountering this issue.

uint8_t HTTPSClient::connected()
{
  return (_sslClient ? _sslClient->connected() : false);
}

from azure-iot-arduino.

yaweiw avatar yaweiw commented on August 22, 2024

@sandeepmistry it can easily be reproduced by not having below lines in your ino file.
Adafruit_WINC1500SSLClient sslClient;
AzureIoTHubClient iotHubClient(sslClient);

from azure-iot-arduino.

sandeepmistry avatar sandeepmistry commented on August 22, 2024

I think a better fix is changing HTTPAPI_Init in src/httpapi.cpp to fail the SSL client is NULL and logging an error.

Would you have time to submit a PR for this?

from azure-iot-arduino.

yaweiw avatar yaweiw commented on August 22, 2024

@sandeepmistry Ok. I'll have a look later.

from azure-iot-arduino.

sandeepmistry avatar sandeepmistry commented on August 22, 2024

Closed via #24.

from azure-iot-arduino.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.