Comments (4)
I am still a bit torn on this. I understand wanting to make the samples/sketches as concise as possible. However, this type of functionality does seem out of scope for the the library itself.
I wonder if there is another NTP library that exists (or maybe one can be made) that we could use in the samples that would limit the code there but just add another dependency.
While NTP and Wifi are requirements for using the library successfully it feels odd to move the configuration of them into the library. Should these libraries want to expose new initial configuration options then this library would also need to be updated instead of just benefiting from new functionality.
from azure-iot-arduino.
@obsoleted good points, I'll submit a patch to this repo to also support non-ESP8266 boards: https://github.com/FWeinb/NTPClient
Then we can use it in the examples like you suggested.
I'll rename this issue accordingly.
from azure-iot-arduino.
I've submitted the following PR to the NTPClient repo: arduino-libraries/NTPClient#8
from azure-iot-arduino.
Closed via #16.
from azure-iot-arduino.
Related Issues (20)
- Missing internal header file HOT 1
- Failed to connect azure iot hub with esp8266 using azure-iot-arduino library HOT 1
- IoT Central example HOT 2
- No Arduino boards actually supported? HOT 1
- Support for Device Provisioning Support HOT 1
- Using IoT Edge certificate instead of Baltimore certificate
- Big Sur compatibility issues
- blob.h is missing HOT 5
- Compatibility with MKR1000 dubious
- blob.h issue for Arduino Nano 33 IoT board HOT 2
- get_epoch_time in iothub_client_diagnostic.c throws errors HOT 1
- Dead link to Huzzah Tutorial in ReadMe
- missing dependencies when updating through library manager
- Arduino Ethernet Shield
- Arduino MKR WIFI 1010 Support
- az_http_client_send_request HOT 1
- upload_to_blob functionality (blob.c and blob.h) HOT 1
- MQTT CONNECT NOT DECLARED IN THIS SCOPE
- While Generating SAS token issue HOT 1
- This repo is missing important files
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from azure-iot-arduino.