Giter Site home page Giter Site logo

Comments (4)

obsoleted avatar obsoleted commented on July 21, 2024

I am still a bit torn on this. I understand wanting to make the samples/sketches as concise as possible. However, this type of functionality does seem out of scope for the the library itself.
I wonder if there is another NTP library that exists (or maybe one can be made) that we could use in the samples that would limit the code there but just add another dependency.

While NTP and Wifi are requirements for using the library successfully it feels odd to move the configuration of them into the library. Should these libraries want to expose new initial configuration options then this library would also need to be updated instead of just benefiting from new functionality.

from azure-iot-arduino.

sandeepmistry avatar sandeepmistry commented on July 21, 2024

@obsoleted good points, I'll submit a patch to this repo to also support non-ESP8266 boards: https://github.com/FWeinb/NTPClient

Then we can use it in the examples like you suggested.

I'll rename this issue accordingly.

from azure-iot-arduino.

sandeepmistry avatar sandeepmistry commented on July 21, 2024

I've submitted the following PR to the NTPClient repo: arduino-libraries/NTPClient#8

from azure-iot-arduino.

sandeepmistry avatar sandeepmistry commented on July 21, 2024

Closed via #16.

from azure-iot-arduino.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.