Giter Site home page Giter Site logo

Comments (3)

RandalliLama avatar RandalliLama commented on August 27, 2024

Is it at all possible that this might be a breaking change? For instance, is there some way that an app might have worked around the current behavior, and that are 'fix' may break the workaround?

from azure-activedirectory-library-for-dotnet.

afshins avatar afshins commented on August 27, 2024

Yes. It has the potential to break existing apps. If the redirect uri registered with AAD is "http://a/" and then app passed "http://a" to ADAL, it currently works, but with the fix, it would fail. So, if we want to avoid the breaking change, we need to apply this fix to v3 only.

Another problem is with receiving redirecty uri as Uri and then expect string match. Uri has its own definition of comparison including adding the missing path and case insensitive comparison. To avoid such confusion, I suggest that we change the type of redirectUri from Uri to string (in v3).

from azure-activedirectory-library-for-dotnet.

afshins avatar afshins commented on August 27, 2024

Fixed.

from azure-activedirectory-library-for-dotnet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.