azywong/p0_unit1_submission

Unit 1 Repository for students to submit their work

azywong.github.io

p0_unit1_submission's Issues

#Letter grade

I had a similar solution to your's to use the reduce method. On reviewing another solution I realized that this soution wont work if the input is not an array!. I learnt a new method called .is_a? which can be used to determine if the input is an Array of 'Fixnum and if its an array use the 'reduce' method. Here is how the code looks -

def get_grade(input)
if input.is_a? Array
average = input.reduce(:+).to_f / input.length
elsif input.is_a? Fixnum
average = input
end

I thought I will share this with you. I didnt know about this before.

# Array total

In your method for Sentence maker , you can try and use the Join method. This will join the elements of an array by the given separator.

e.g:- if I have an array of array = ["x","y","z"]

and I do - array.join(",") it will give me "x,y,z".

Apart from that I think your code looks good. Your variable names are well-defined and pseudocode is easy to follow.