b13/authorized-preview

TYPO3 Extension for previewing disabled languages without a backend login

authorized-preview's Issues

PHP 8.1 compatibility

This extension should be compatible with PHP 8.1.

PHP Warnings in Middleware, TSFE not set

I get a lot of warnings in the log like this:

Core: Error handler (BE): PHP Warning: Attempt to read property "id" on null in /.../ext/authorized_preview/Classes/Http/Middleware/Preview.php line 114
Core: Error handler (BE): PHP Warning: Undefined global variable $TSFE in /.../typo3conf/ext/authorized_preview/Classes/Http/Middleware/Preview.php line 114

Maybe this is caused by some subrequest, e.g. solr? 🤷 I guess it should be safe to to add something like this?

if (!isset($GLOBALS['TSFE']) || !$GLOBALS['TSFE'] instanceof \TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController) {
        return $handler->handle($request);
    }

TYPO3: 11.5.27
authorized_preview: 2.1.0 and 3.0.0

[Feature Request] add functionality for preview urls on activated languages as well

Hi,

your extension was recommended to me by @bmack and maybe your extension could be extended...

We have the following use case:
An editor creates a new page. This page is hidden at first because the editor needs an approval from another person before the page can go live. Therefor the editor has to send the preview url to this person. Right now that is possible only with workspaces. In Workspaces you have the option to generate a preview url. So the editor created a new page, switches to the Workspace and copies the preview url, sends the url to the other person...

It would be good if workspaces are not needed in order to copy a preview url for people who are not logged-in into TYPO3 (or doesn't have a TYPO3 account).

Maybe this feature could be added, so that the preview url not only works for pages with deactivated languages but also for pages with activated languages?

Thank you very much.

Cookies are not set via PSR-7 Response

The current implementation uses setcookie which does not allow to use this extension as subrequest.

https://github.com/b13/authorized-preview/blob/master/Classes/Http/Middleware/Preview.php#L89

TYPO3 Core uses it differently https://github.com/TYPO3/TYPO3.CMS/blob/87dd80d5810e1e8f559b5a9584f423c4dada4544/typo3/sysext/core/Classes/Middleware/BackendUserAuthenticator.php#L74

Latest version 2.0.0 is not available in Extension repository

• TER: https://extensions.typo3.org/extension/authorized_preview
• packagist: https://packagist.org/packages/b13/authorized-preview