Giter Site home page Giter Site logo

babykarte.github.io's Introduction

Welcome to the repository of Babykarte

https://wiki.openstreetmap.org/wiki/Baby-Karte

Run Babykarte locally

In order to run a local copy of this branch perform these steps:

  • Clone this branch locally
  • cd into the new repository
  • Run python3 -m http.server 8080

Easy, isn't it? That's all! Just open http://localhost:8080/ in your browser and have fun :) For the Babykarte to work you need an active internet connection.

Just close the terminal or press Ctrl+Alt+C in the terminal to end the server. NOTE: All devices in your intranet can access your local copy of Babykarte. This enables you to use your local copy of Babykarte also on your mobile device.

Like to contribute

You're a (hobby) designer, (hobby) developer, (hobby) translator or something else and want to contribute to Babykarte. Great idea and thank you in advantage! There are various ways of doing it. It is enough to open an issue but you can also do it yourself by following the contribution guide. The guide makes the process of reviewing, discussing and validating easier for us and speeds it up so your contributions hopefully show up in a short period of time.

babykarte.github.io's People

Contributors

discostu36 avatar goldfndr avatar jarek avatar mattsches avatar nicolasgrosjean avatar slowmo24 avatar valornaram avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

babykarte.github.io's Issues

Icons needed

We need icons (symbols) for Babykarte. Where to get OR can we create these by ourselves?

New markers design

New markers are too big and the middle is at the correct coordinates instead of the tip. Maybe just take the old design for v1 (with multiple colors), we can redesign for future versions.

Diaper filter

The diaper filter isn't correctly implemented yet:

  • We don't need a separate toilet filter
  • Diaper filter should be something like "(amenity=toilet|shop=chemist)" AND "diaper=*" WITHOUT "diaper=no"

Komplexe Anfragen funktionieren noch nicht

Folgende Filter funktionieren noch nicht:

baby_keys.set("Kinderärzte", "\"healthcare\"=\"doctor\";\"healthcare:speciality\"=\"paediatrics\"");
baby_keys.set("Kinderkleidung einkaufen", "\"shop\"=\"clothes\";\"clothes\"=\"babies\";\"clothes\"=\"children\"");
baby_keys.set("Puppentheater", "\"amenity\"=\"theatre\";\"theatre:genre\"=puppet\"");

Es werden jeweils fehlerhafte Anfragen an die API gestellt:

https://overpass-api.de/api/interpreter?data=[out:json][timeout:15];(node[0][1](49.22724961059236,7.015655636787415,49.22813418328701,7.01841026544571);way[0][1](49.22724961059236,7.015655636787415,49.22813418328701,7.01841026544571);););out%20body%20center;
https://overpass-api.de/api/interpreter?data=[out:json][timeout:15];(node[0][1][2](49.22724961059236,7.015655636787415,49.22813418328701,7.01841026544571);way[0][1][2](49.22724961059236,7.015655636787415,49.22813418328701,7.01841026544571);););out%20body%20center;
https://overpass-api.de/api/interpreter?data=[out:json][timeout:15];(node[0][1](49.22724961059236,7.015655636787415,49.22813418328701,7.01841026544571);way[0][1](49.22724961059236,7.015655636787415,49.22813418328701,7.01841026544571);););out%20body%20center;

SEO

Some basic SEO (meta description, keywords) should be added to index.html

Add marker color to filter selection

Please add the colors of the markers to the filter selection (e.g. as a little dot or little square between check box and word). This way it's easier to see what kind of POI the marker does indicate.

Changes to contact tab

  • Also provide telephone numbers and URLs as text next to the icons (list with Icon left and text right)
  • Add social networks (Facebook, Instagram)

Language system bugs

Changing languages after selecting filters still leads to bugs. No high priority, but some day this should work.

Shorten URLs

Shorten URLs that don't fit into a single line

Unbenannt

privacy policy update

I've updated the english privacy policy. Needs to be translated to German and converted again.

Steps left to publication of v.1

  • translating of privacy policy into english
  • minor works in the POI details view
  • embedding privacy policy into the language infrastructure
  • waiting for #17 to be solved
  • submit for publication (needs an approval)

Parks not shown

The query for parks doesn't work yet, they are not shown on the map.

Add some tags to the info tab

The info tab is quite empty, it could show some additonal information:

  • operator=
  • description=

*) German version should show description:de, if available, English version description:en

Filter ohne Button aktivieren

Es sollte möglich sein, die Filter zu aktivieren, ohne eine zusätzliche Schaltfläche klicken zu müssen. Also direktes Absenden der Abfrage, sobald angehakt wird.

Better pop-up subtitle

Subtitles of pop-ups shouldn't name the filter ("changing tables") but the main tag of the POI ("chemist"). Ideally, we'd have a list where we can easily add "translations":

EN: {
"shop=chemist": "Chemist";
"amenity=toilet": "Toilet"; 
}

DE: {
"shop=chemist": "Drogerie";
"amenity=toilet": "WC";
}

Filter name could still be a fall back for keys that are not listed.

Datenschutzerklärung ergänzen

  • Verantwortlicher (Michael)
  • IP-Adresse wird auch vom Github-Server geloggt?
  • Wie lange werden Daten gespeichert (jeweils)
  • Datenschutzerklärung auf Website veröffentlichen (sobald es die gibt)
  • Cookies (wer welche und warum und wie kann man es verhindern)

[...]

Ready for deploying

All steps are done, now we come to the final - the publication of Babykarte by activating its domain http://babykarte.github.io/ as we discussed in #19 .

Lists

List of special sites:

  • Impressum ( impress.html )
  • Impress (impress.html )
  • Datenschutzerklärung ( privacypolicy-de.html )
  • Privacy Policy ( privacypolicy-en.html )

The main page:

  • Babykarte ( index.html )

Others:

  • Following Branding rules for the Facebook logo (See this example of the use in Babykarte and check the compliance with Facebook's rules)

Perhaps you want to check all of these before activating the domain or you leave the check out. It's your choice.

How to activate the domain?

  1. Go to settings of this repository.
  2. Scroll down to Github Pages
  3. Select from the None dropdown list the master branch (it's the branch we're currently in and what we use for working releases. Reminder: We've talked about branches and how I am going to handle further commits into this repository. For v2.0 I create another branch where I upload the commits to v.2.0)
  4. You may also want to rename this repository Baby-Karte to babykarte in order to have http://babykarte.github.io/ instead of http://baby-karte.github.io/

Url name

It's time to specify the URl

I would suggest http://babykarte.github.io because Babykarte or Baby-Karte is the project title and the project title should be also the url name.

I don't suggest http://babymap.github.io because it would break the project title Babykarte or Baby-Karte and therefore not intuitive.

International doesn't matter because every western keyboard can write babykarte and the word is not as extremely difficult to remember. I see some spanish urls on the web and they aren't also difficult thought I don't remember these because I don't visit spanish websites so often.

Remove animals and puppet theatres

Please remove these two filters. Both were added by someone else to the specification, and they are not useful. Animal attractions are already covered with "zoo" and puppet theatres are too rare.

Add links

Somewhere on the site should be links to the GitHub repository and to the Wiki page. I'm not sure yet, where to place them best.

Filter issues

A collection of small issues concerrning filters:

  • New filters only get added when clicking "Filter anwenden". The same behaviour should be used for removing filters.
  • The same is for filters that were already selected. Now they do appear immediately. I understand the reason behind that but it's not intuitive for the user.
  • The loading bar moves to the middle and stays there, when no content is found (no filter selected or no fitting POIs on the map)

Fix mobile view

Mobile view of the page has to be fixed:

  • Menu button does not work
  • Search bar is cut of
  • Links are not visible
  • Horizontal and vertical scroll bars are visible

grafik

Tablet view

I'm not sure how important tablet resolutions are. So maybe this can wait until after v1 release.

Not all tablet resolutions look good yet.

tablet

More visible loading indicator

It would be nice to have a more visible loading indicator that shows whether data is still being loaded from Overpass API.

I only noticed the progressbar from searching the code for researching the effort to implement a loading indicator. The progressbar does not catch the eye.

I'll try and provide a pull request.

Enhance baby friendliness page in popup

Just that I don't forget, some changes I'd like to have in the next version:

  • Entries should be color-coded (yes=green, limited=yellow, no=red)

  • Missing tags should be shown, but greyed out

  • Sub-tags should be shown as sub-items

  • Description tags should be used (e.g. stroller:description=Only first floor is accessible):

The result could look something like this:

baby_color

Fixing the specification

Until v.1 is being released I don't develop changes made to the specification into Babykarte immediately.

The specification is now fixed for v.1 Reasion: Prevention / Speeding up v.1's release process

Users are able to make changes to the spec, but these changes do not appear in v.1 of Babykarte.

Opening hours

Due to some problems in the implementation of opening hours in Babykarte, it remains without it.

Meaning v.1 will be developed and published without this implementation when no solution can be found during this period.

Changelog

Should we create a changelog or something like that? A place where we document the different versions, when they were released, what was changed?

excluding tags

I haven't found out yet how to do this with overpass, but we should add some excluding tags. This means that elements, that do have one of these tags, shouldn't be shown on the map:

Maybe there are more I can't think of right now.

Highlight the search results area

The search results area's background is white as the area left of it. Maybe it should be have a visible border or other background color to distinguish the both areas better.

Questions to the specification

I have some questions regarding the specification:

healthcare=birthing_center

What's that and how to name the filter?

health_facility:type=counselling_centre, counselling_type:child_guidance=yes oder counselling_type:family=yes

What's that and how to name the filter?

addr:street bug

addr:street isn't always correctly parsed. Maybe a problem with ß?

addr:street=Schloß Nymphenburg

undefined

Zoom problems

There is still some buggy behavior when zooming out after applying a filter. Quite often, not all markers are shown that should be shown.

Maybe we should remove the dynamic loading of additional POIs? Then we could just rename the button from "Apply filters" to "Refresh map" and the user has to refresh every time when changing selection or map view.

But this is of course not very convenient, especially on a mobile device. Do you know another way how to fix this?

Popup issues

Missing information or display bugs in popups:

Baby features

  • diaper:female is not shown

Contact tab:

  • Line break is missing before Facebook link
  • (With danger of getting on your nerves:) Please move link from symbols to text

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.