Memory leak using "LifecycleExt.kt"

[ultraon]

Memory leak using "LifecycleExt.kt"

[arkivanov]

Will be delivered in version 2.1.0

[arkivanov]

Hi @ultraon and thanks for the feedback!

All those extensions were designed to be called only once for the lifetime, and so calling them from onStart on onResume is currently considered incorrect. But you are right, calling doOnStop from onStart or doOnPause from onResume actually makes sense.

What do you think about the following API?

inline fun Lifecycle.doOnStop(isOneOff: Boolean = false, crossinline onStop: () -> Unit) {
    // ...
}

If the isOneOff flag is set to true then the callback will be removed automatically. Maybe you can find a better name for the flag?

[ultraon]

Why do you think returning Disposable (or you can name it in another way) is worse? It is more flexible and controllable by a client side.

I can understand your intention in terms of KMM and extensions e.g. Reactive/Suspend, in this case I would agree with your suggestion, regarding naming I think you may also consider oneShot, oneTime (this term is used by Android WorkManager lib - OneTimeWorkRequest), singleCall, singleEvent.

[arkivanov]

My intention here is to simplify as much as possible most common use cases. For advanced use cases there are main Lifecycle.subscribe and Lifecycle.unsubscribe methods. So you can either use it directly or add your own extensions.

[ultraon]

Yes, you are right, thanks for the hint!

[arkivanov]

Alright, I will add the argument, thanks!

[arkivanov]

Fixed via #259