Comments (2)
Hello @ultraon and thanks for the idea!
First of all I would like to stress, that providing the CoroutineScope
as a property
was an explicit design decision. Making custom classes to implement CoroutineScope
is discouraged, according to docs, various messages in Slack and some articles: Docs page, A slack thread, An article. The main reason is that it's error prone, you my accidentally launch a coroutine in incorrect scope.
Passing a scope via constructor - currently I find this also not a good API. CoroutineExecutor
closes the scope on dispose. Currently CoroutineScope
is encapsulated (owned and controlled by the CoroutineExecutor
), and so its lifetime is guaranteed to be between CorutineExecutor
instantiation and disposal. Passing CoroutineScope
via constructor removes ownership from CoroutineExecutor
.
If you still really won't to implement CoroutineScope
, then maybe you can create your own base class?
open class BaseExcecutor(...) : CoroutineExecutor(...), CoroutineScope by scope {
...
}
from mvikotlin.
Itβs a pretty good explanation, thank you.
from mvikotlin.
Related Issues (20)
- Add watchOS support HOT 2
- Deploy JS sample app to hosting as working example HOT 1
- Memory leak using "LifecycleExt.kt" HOT 7
- Unit Testing the CalculatorStoreFactory (from the website tutorial)... ???
- Rename SuspendExecutor to CoroutineExecutor and SuspendBootstrapper to CoroutineBootstrapper HOT 1
- Can't export time travel data HOT 3
- BypassReducer does nothing HOT 2
- Support new Apple silicon targets
- Try to allow Stores with same names when using time travel
- Add settings dialog to the time travel IDEA plugin HOT 1
- Describe the time travel feature in more detail HOT 2
- Add binary-compatibility-validator plugin to all published modules
- Consider better names for Action and Result HOT 3
- TimeTravelServer for web HOT 1
- Broken links in the time travel docs HOT 1
- Setup CI for publishing the time travel desktop app HOT 1
- Update KDocs in CoroutineExecutor HOT 5
- How to work around bootstrapper action publishing label before listener set up HOT 5
- Mvi
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mvikotlin.