baffinlee/readline-reverse

📑 readline reversely in nodejs

readline-reverse's Issues

Small bug

Hey,
Thanks for the code. I ran into a bug that triggers when the last READ_TRUNK call doesn't have a new line.

// Original
const { bytesRead } = await read(this[FD], this[BUFFER], 0, this[BUFFER].length, Math.max(position, 0))

FIX 
const { bytesRead } = await read(
  this[FD],
  this[BUFFER],
  0,
  Math.min(this[BUFFER].length, this[FILE_POSITION] + 1), // This argument makes the read call only read whats needed
  Math.max(position, 0)
)

I have a file that can trigger the bug but I don't think there's a way to send attachments