bahlo/go-styleguide

🏆 Opinionated Styleguide for the Go language

I'm Arne Bahlo, a software engineer from Germany.

go-styleguide's Issues

Deprecation of gometalinter

As the title describes - gometalinter is now deprecated and will be archived on 2019-04-07.
https://github.com/alecthomas/gometalinter

They recommend to switch to https://github.com/golangci/golangci-lint

Another alternative to reflect.DeepEqual

Considering https://github.com/bahlo/go-styleguide#avoid-deepequal you can give a try to https://godoc.org/github.com/maxatome/go-testdeep :)

code in directory ...\github.com\uber-go\zap expects import "go.uber.org/zap

Hi：
when i try to run this snippet (Structured logging):

import "github.com/uber-go/zap"
//...
logger, _ := zap.NewProduction()
defer logger.Sync()
logger.Info("Server started",
        zap.Int("port", port),
        zap.String("env", env),
)

console output:

main.go:6:2: code in directory D:\golang\src\github.com\uber-go\zap expects import "go.uber.org/zap"

I changed "import github.com/uber-go/zap" to"import go.uber.org/zap" and then the result is right .

Best regards!

jinkun

Break can not jump out of the loop-for

Don't under-package
there is a problem in example code :

break func main() {
	logger := // ...
	sc := make(chan os.Signal)
	done := make(chan bool)

	go func() {
		for {
			select {
			case s := <-sc:
				logger.Info("Received signal, stopping application",
					zap.String("signal", s.String()))
				break   //<---this break can not jump out of the loop
			default:
				time.Sleep(1 * time.Second)
				ioutil.WriteFile("foo", []byte("bar"), 0644)
			}
		}
		done <- true   //can not handle this
	}()

	signal.Notify(sc, os.Interrupt, os.Kill)
	<-done // Wait for go-routine
}

go modules should be added.

I think adding go modules to "Dependency management" would be a good idea

go-bindata is archived

As the title says https://github.com/jteeuwen/go-bindata is archived and unmaintained. The original author deleted the account and later someone registered it and just uploaded the library back. There is also some confusion around a go-bindata organization.

So instead of linking it, I would suggest adding a link to this page instead which compares many different libraries: https://tech.townsourced.com/post/embedding-static-files-in-go/