bainternet/tax-meta-class

A class for creating WordPress taxonomies custom fields

tax-meta-class's Issues

Input Styling Missing

Thanks for a great Class!

I notised that most of the fields do not apply styles passed on. From what I can see the only thing missing is {$field['style']}

To take one example on line 717 I changed show_field_text():

value='{$meta}' size='30' />

to:

value='{$meta}' {$field['style']} />

and on line 1411 I changed addText();

$new_field = array('type' => 'text','id'=> $id,'std' => '','desc' => '','style' =>'','name' => 'Text Field');

to:

$new_field = array('type' => 'text','id'=> $id,'std' => '','desc' => '','style' =>'size="30"','name' => 'Text Field');

Missing enctype="multipart/form-data" brackes file upload

Missing enctype="multipart/form-data" brackes file upload

Inserting url paths and class names or any quotation marks produces backslashes

Even when using the wysiwyg field type... it still places escapes on all quotations. this means an urls entered in will not work properly.

File uploader quietly fails on large files

When I save a term with a file that exceeds the max upload size, there is no error generated and the term is saved successfully. Would be preferable to have an alert notifying the editor that it did not save correctly.

Use WP 3.5 Media Uploader

Hi there,
Thanks a lot for this helper class, it's very useful. I'd just like to know if you're planning to implement the WP 3.5 new media uploader?
Thanks!

Image field is not associated to category ( don't see the image when editing )

As per title, i've added an image field to my Event Category page ( it's a custom post type ) but when i edit the category, the image is not shown on the page

Parse error in 1.8.7

Parse error: syntax error, unexpected '&' on line 1297

Errors in 1.8.6

Hi,

I found two errors in the 1.8.6 version:

line 1069 : $taxnow = ; (should be $taxnow = $_POST['taxonomy']; ? )

line 1298 I have this error : " Invalid argument supplied for foreach() "

Anyway,
In 1.8.5 and 1.8.6 the arg "multi" is never used in the function get_tax_meta ?

I can't retrieve a repeated block content with the get_tax_meta($my_id,$my_name,true); (both variables are sets and corrects), can you help me?

thanks :)

Category images - unattached

So everytime you upload an image through the wordpress media uploader it is assigned as attached or unattached to a post. If it is unattached then in the DB it is assigned as parent-post = 0 …. now this makes sense why this would happen in this instance, due to the fact that there is no built in method in wordpress to attach media to cat or tax id’s only post-ids as parent-posts.

The problem is, like many people I don’t want to have attachment pages accessible to users/search engines. so if a user were to somehow stumble upon a link to website.com/?attachment=5 then with use of a function it could permanently redirect back to the post parent of the attachment; i.e. the post/page/CPT that was being modified/added when the image was added. This can’t possibly work as is with your framework, as there is no direct connection from the wp_post attachment that is an image uploaded using the tax-meta class and the category/taxonomy ID.

I can think of 2 possible ways --both are pretty bad:

1. Add a column to a tax table…this is pretty bad idea I think.
2. Query the database for the same src url as the attachment page the user is currently on against the tax_meta_n data sets in the options table, theoretically this will always work if an image isn’t used on 2 different taxonomies. Not a good solution either, this could lead to a ridiculous amount of data to sift through.

Both of those ideas aren’t great to say the least, but I feel like we need to be investigating a solid solution, because based on my understanding this is creating a bit of an SEO leak, isn’t it? I am not claiming to be an SEO expert at all, based on what I have read though that seems to be the idea.

The function I am currently using to redirect to post_parent page is:

add_action( 'template_redirect', 'attachment_redirect', 1 );
// Redirect any attachment page to their parent with 301 redirection

function attachment_redirect() { global $post; if ( is_attachment() AND isset( $post->post_parent) AND is_numeric( $post->post_parent ) ) { wp_redirect( get_permalink( $post->post_parent ), 301 ); exit(); } }

Issue with "Quick Edit" of category when an image field is added to the category pages

I've added an image field to the categories for a custom post type. The only error i keep getting is that if i choose to quick edit a category and then i press "Update category" the server responds with the following html

 Are you sure you want to do this?</p><p><a href='http://localhost/wordpress/wp-admin/edit-tags.php?taxonomy=events_categories&#038;post_type=ai1ec_event'>Please try again.</a>

while normally it should simply save the category and return the html for the categories

Jquery UI Not Showing Up in Related Fields

The date picker never pops up for example. I'm pretty confused.

array merge warning in debug mode

Put WP in debug mode by setting this in wp-config.php:
define('WP_DEBUG', true);

Logout of the admin console and you'll see this at the top:
Warning: array_merge(): Argument #2 is not an array in D:\XXX\wp-content\themes\XXX\Tax-meta-class\Tax-meta-class.php on line 1290

Undefined index: multiple and Undefined index: std on line 497 - 498 when displaying an image field

I'm getting notices on these lines

      $meta = $this->get_tax_meta( $term_id, $field['id'], !$field['multiple'] );
      $meta = ( $meta !== '' ) ? $meta : $field['std'];

Bad implementation

I see 2 problems in the plugin design:

1. Use the table of options is bad for performance and maintainability. Just use WP API Meta, with a custom table, as : https://github.com/herewithme/meta-for-taxonomies
2. The plugin uses only term_id to store information. And term_id can be used by two different taxonomies, and thus generate conflicts for the user. This situation is rare but possible in WP application. You must used term_taxonomy_id or use the pair taxonomy / term_id to avoid problems

wysiwyg in repeaterblock

Hi, if i use a Wysiwyg editor in a repeaterblock then only the + button is shown without functionality. It seems to be a JS Bug. Firebug says:

SyntaxError: unterminated string literal

...<a id="blockre_[' + countadd_blockre_ + '][blockre_textarea_field_id]-html" clas...

Here the generated code from Tax-meta-class:

<script> jQuery(document).ready(function() { var countadd_blockre_ = 0; jQuery("#add-blockre_").live('click', function() { countadd_blockre_ = countadd_blockre_ + 1; jQuery(this).before('

Titel			Beschreibung	HTML Visuell Hochladen/Einfügen <textarea class="at-wysiwyg wp-editor-area" rows="20" cols="40" name="blockre_[' + countadd_blockre_ + '][blockre_textarea_field_id]" id="blockre_[' + countadd_blockre_ + '][blockre_textarea_field_id]"></textarea>

'); update_repeater_fields(); }); jQuery("#remove-blockre_").live('click', function() { jQuery(this).parent().remove(); }); }); </script>

Problem with links

Hello and thank you for a great function!

I'm using it on my category pages (category.php) to display some extra information. I have one problem though, that I can't seem to work out.

When adding a link in the wysiwyg box, or the text box, I have tried them both, this is what happens:

I add the url like this:

<a href="http://mysite.com/post-slug/" title="My title">Link text</a>

The output, when I fetch the data on the front end, becomes this:

<a href=\"http://mysite.com/post-slug/\" title=\"My title\">My Link text</a>

Which makes WordPress interpret the URL like this:

http://mysite.com/"http://mysite.com/post-slug//"

This is how I'm fetching the data on the front end:

<?php 
$category_text = get_tax_meta(get_query_var('cat'),'wysiwyg_field_id');
echo wpautop($category_text);
?>

I have tried it with and without wpautop, which doesn't seem to make a difference, so the problem seems to be with the function?

Or have I missed something?

Thanks for your help!

// Jens.

get_tax_meta with repeater fields

So, I created a repeater field using the following code:

$repeater_fields[] = $my_meta->addDate($prefix.'air_date',array('name'=> 'Air Date'), true);
$my_meta->addRepeaterBlock($prefix.'episode_',array('inline' => true, 'name' => 'Air Dates','fields' => $repeater_fields));

Then, when it comes time to access the data in the template, I've tried:

$air_dates = get_tax_meta( $episode_id , 'air_date', true);

No success. I looked in the class and, unless I'm missing something, it doesn't appear that the function is setup to handle $multi?

Any ideas on how I can get this working?

Typo for the validation class

Hi.

Thanks for your work on this great tool.

There's a typo in your validate_func call, line 1093:

if ( class_exists( 'Tax_Meta_Validate' ) && method_exists( 'Tax_Meta_Validate', $field['validate_func'] ) ) {
  $new = call_user_func( array( 'at_Meta_Box_Validate', $field['validate_func'] ), $new );
}

should be:

if ( class_exists( 'Tax_Meta_Validate' ) && method_exists( 'Tax_Meta_Validate', $field['validate_func'] ) ) {
  $new = call_user_func( array( 'Tax_Meta_Validate', $field['validate_func'] ), $new );
}

Metadata record (wp_options) not deleted when taxonomy record deleted

If I create a new taxonomy record ('newsletter') with ID 6, the wp_options table gets a new record with option_name = 'tax_meta_6'. When I delete the taxonomy record (newsletter 6) the record in the wp_options table persists.

Doesn't cause issues as such, but I can see this accreting a lot of junk records over time. This snippet below sorts it - I'm not sure if it's appropriate to include this hook automatically when the class is invoked?

function delete_taxonomy_metadata($term_id) {
delete_option( 'tax_meta_' . $term_id );
}
add_action('delete_term', 'delete_taxonomy_metadata', 10, 1);

Undefined index multiple on line 1087 when posting an img

This breaks the json response

<b>Notice</b>:  Undefined index: multiple in <b>C:\Program Files (x86)\Zend\Apache2\htdocs\wordpress\wp-content\plugins\all-in-one-event-calendar-premium\lib\Tax-meta-class\Tax-meta-class.php</b> on line <b>1087</b><br />

This is the code responsible

$old = $this->get_tax_meta( $term_id, $name, ! $field['multiple'] );

I fixed this with

      $multiple = false;
      if( isset( $field['multiple'] ) ) {
        $multiple = $field['multiple'];
      }
      $old = $this->get_tax_meta( $term_id, $name, $multiple );

Dont' know if this is correct

tax-meta-clss.js not enqueuing

I have an addDate field set in a repeater as well as an addImage field. For some reason, the javascript file isn't being enqueued. The CSS is, though. I edited the check_field_date function to only do a check on is_edit_page - a quick work-around that gets me back up and running.

Here's a reference to my setup file: http://pastebin.com/JkYrpQSd

required fields

Hi

thanks for this useful class, I'm using it in my plugin
does it account for making fields required?

new taxonomy with an image field

After adding a new taxonomy with an image field, all other fields will be cleared out, but the image is still here, now we can't click the "delete image" button, because this image is used by previous taxonomy. And, it's helpless to refresh the page. Now, if i want to add a new taxonomy, the only thing I can do is leave this page then return again.

Adding custom taxonomy with repeater block

Hi! Great plugin ;)
I'm using a repeater block in my custom taxonomy page.
When I try to add a new category nothing happens.
The category is added but when i click the "add" button the list doesn't refresh its content.

If I remove the repeater block works like a charm. Any ideas?

JS and CSS isn't inserted when using a child theme

I just tried using this on a child theme for twentyeleven, however, due to the class using get_template_directory_uri() to determine the root, it won't work. It should be get_stylesheet_directory_uri().

It may even be better to just use dirname(__FILE__).

How to use the class when using custom post types?

Hi, i'm going to use your class with our plugin that handles events as a custom post type. Any advice on where i should start to look to adapt your class in such a way that it show the extra field only on the "Categories page" of the desired post type?
I use the "Event" custom post type so i would want an extra field only on the "Event categories" Page

Shortcode in the text field?

Is there a way of allowing shortcodes in the text type fields? The Wysiwyg field is overkill for just a shortcode.

Thanks!
John

Image uploader fails

Experienced this while integrating into a theme, so I tried on a fresh install...

Apache 2.4
PHP Version 5.3.11
Win 7
Firefox 11

WP 3.3.2
TwentyEleven theme
No other plugins activated other than test plugin, only other plugins in folder are Akismet and hello

Created a test plugin that adds only an image upload button to the categories page.

On loading Posts > Categories, Upload button appears. On button click, uploader appears.

On drag/drop, browser goes to location of image. In other words, admin page disappears and is available via back button, browser location bar shows file address.

On image select using Select button in uploader, file select window loads. Select file, click OK, file select box closes, then nothing happens in the media upload box. Just sits there.

Code used in test plugin:

<?php
/*
Plugin Name: Demo Tax meta class
Plugin URI: http://en.bainternet.info
Description: Tax meta class usage demo
Version: 1.7.4
Author: Bainternet, Ohad Raz
Author URI: http://en.bainternet.info
*/
require_once("Tax-meta-class/Tax-meta-class.php");
if (is_admin()){
  $prefix = 'ba_';
  $config = array(
    'id' => 'demo_meta_box',          // meta box id, unique per meta box
    'title' => 'Demo Meta Box',          // meta box title
    'pages' => array('category'),        // taxonomy name, accept categories, post_tag and custom taxonomies
    'context' => 'normal',            // where the meta box appear: normal (default), advanced, side; optional
    'fields' => array(),            // list of meta fields (can be added by field arrays)
    'local_images' => false,          // Use local or hosted images (meta box images for add/remove)
    'use_with_theme' => false          //change path if used with theme set to true, false for a plugin or anything else for a custom path(default false).
  );
  $my_meta =  new Tax_Meta_Class($config);
  $my_meta->addImage($prefix.'cat_thumb',array('name'=> 'Cat Image '));
  $my_meta->Finish();
}

Repeater Block not Saving with 0 Entries

I have a repeater block meta tag and it's currently not saving with 0 entries against it. Here are my steps:

1. Open Category with 1 entry in the repeater block against it.
2. Delete the entry against the repeater block.
3. Save the Category.
4. Return to the Category and repeater entry remains.

hyperlinks are not working when used in the extra fields

I am using the tax-meta-class and it works fine. I am displaying the wysiwyg field on the archive pages for categories. However having hyperlinks in the wysiwyg field will not work on the site. It returns a Error 404.

I have the following text filled in text area or wysiwyg filled:

<h1>Geschiedenis</h1>
Deze geeft een overzicht van alle documentaires betreffende 
<p>
See <a href="http://www.w3.org/>W3C</a> for further information.
<p>

The site is showing an hyperlink however it depicts the following text in the statusbar below when hovering over this link:

www.docu-tube.nl/"http://www.w3.org/

When clicking on the hyperlink it triggers the Error 404 with the following in the address bar of the webbrowser:
www.docu-tube.nl/"http:/www.w3.org/...

It is not working because the domain before the " is included and one slash has been removed from the hyperlink.

Please help....

Delete should not remove images only the option

I'm using this class to add metadata to a custom taxonomy. One of those metadata is an image. When editing that metadata you are presented with the thumbnail of the image and a button 'Delete' as the only option. So if you want to change the value you have to delete the image.

This is in my opinion totally wrong. In Wordpress images should only be deleted in the media library. Why? Because images can be shared in different places of the site, that's how the media library works.

For example I can have an image as featured image of a post and at the same time use it as metadata for a category. Deleting the metadata on the category shouldn't affect the featured image of the post. Deleting the metadata of the category should only remove that metadata (just removing the options value not the image). This is exactly how core works. If you edit a featured image clicking the button 'remove featured image', you don't actually remove the image only it is not the featured image anymore but the image is still part of the image library.

This class works fantastic and it is very easy to work with it but this is in my opinion a huge mistake.

Unless there is something I'm not taking into account and there is a configuration option to prevent images from being deleted.

checkbox display description twice

checkbox display description twice

Files mising when using file field

after adding a file, update and add more files the old files are missing.

Use of external url with media uploader & filtering inputs

Hi Raz,

First, i'd like to say a big thank you for your work on this class, it will give me a good help in my next project.

I've played with it tonight, and as i like to use external urls for my images, i've noticed that you only save an image meta if an attachment id is provided.. In my case, there's not, so the image is not saved in tax meta :(

Suggestion to make it work for external urls

So i've edited your javascript file tax-meta-clss.js inserting these lines after line 311 :

       else if( val.indexOf("wp-image") == -1 && load_images_muploader_check_is_image( imgurl ) ) {
        // it's an external url image
        att_id = 0;
        return true;
    }

Then i inserted my quick and dirty load_images_muploader_check_is_image function elsewhere up in the file to check that the url is leading to an image file (as it's possible to link to other media file.

function load_images_muploader_check_is_image( image ) {
        var isimage = false;

        if( image.substring(image.length -4).indexOf('.jpg') != -1 )
            isimage = true;

        else if( image.substring(image.length -4).indexOf('jpeg') != -1 )
            isimage = true;

        else if( image.substring(image.length -4).indexOf('.png') != -1 )
            isimage = true;

        else if( image.substring(image.length -4).indexOf('.gif') != -1 )
            isimage = true;

        return isimage;
  }

That fixed my issue, it seems my edits didn't break everything, but i guess it needs testing..

Suggestion about tax meta updates

Finally i have a suggestion to make about data insertion in db. I've tried to add a simple javascript in a text field and then echoed it on front.. And it popped. So even if i don't imagine an admin doing such tests on their sites, i simply advise you to add a filter just before saving the meta in your update_tax_meta functions. For example :

$m[$key] = apply_filters( 'tax_meta_class_update_meta', $value );

Then admins will be able to eventually sanitize the inputs by adding this kind of filter :

function tax_meta_class_update_meta_filter( $meta ) {
    return wp_kses( $meta, array() );
}

add_filter('tax_meta_class_update_meta', 'tax_meta_class_update_meta_filter', 10, 1 );

Again, thanks for the great work and best wishes (we'll soon be in 2013 ;) )

Meta from other plugin blends with this

Using WPML plugin along with this plugin creates a bug:

The wpml meta for taxonomy (different languages) gets mixed with the meta from this plugin. The meta from this plugin gets duplicated into the meta from WPML. Most likely because they both overwrite the insert to post button.

Add text domain

Nice plugin

Add text domain in Tax-meta-class.php. You have not included a text domain!

Thanks

addPosts not accepting custom post type value

Following the example, I attempted to implement an addPosts field for a custom post type of "show". I used the following:

$my_meta->addPosts('episode_show',array('post_type' => 'show'),array('name'=> 'Show'));

On load, it pulled instead from the default "posts". I investigated the addPosts functions to find the problem. It seems like there may be a structuring problem. To work around it, I modified the $q variable as such:

$q = array('posts_per_page' => -1, 'post_type' => 'show');

It worked beautifully.

Naturally, my work-around will just work for me. I wanted to bring the difficulty to your attention to help avoid the same trouble with others.

Small error in css file stops parsing of css

You have an error on this line

.wp-editor-wrap{{width: 500px;} 

should be

.wp-editor-wrap{width: 500px;} 

This prevents css from applying correctly

WYSIWYG content doesn't save on new category

First, thank you for this very helpful library!

I've added some tax meta to categories in a plugin I'm writing, and it seems that the WYSIWYG field does not save correctly when creating a new category.

To reproduce:

• Add wysiwyg tax meta to categories
• Fill in wysiwyg editor in the "new category" form
• Save category
• Go to "edit category" screen for the category you just created
• See that the wysiwyg field is blank

I will look into patching this - for now I just wanted to bring it to your attention in case it is a quick fix.

Image upload doesn't work

require_once("classes/Tax-meta-class.php");
if (is_admin()){

$config = array(
'id' => 'demo_meta_box',
'title' => 'Demo Meta Box',
'pages' => array('ntp_package_type'),
'context' => 'normal',
'fields' => array(),
'local_images' => true,
'use_with_theme' => true,
);

$my_meta = new Tax_Meta_Class($config);

$my_meta->addTextarea('textarea_field_id',array('name'=> 'Textarea '));
$my_meta->addImage('image_field_id',array('name'=> 'Image'));

$my_meta->Finish();
}

Textarea works but the image upload button just changes color on hover and doesn't do anything.

Image uploader not functioning

Hello Ohad.

I have an identical problem to NestedWeb viz: #34

Text fields function be the image upload button just doesn't do anything.

My code is as follows. I have tried all the tips others have suggested to change the directory in tax-meta-class.php to no avail so I have reverted to the original class.

Please find the below the code from my theme functions - do let me know what more I need to give you to help find the issue.

Your help is hugely appreciated! Ben

require_once("Tax-meta-class/Tax-meta-class.php");

$config = array(
'id' => 'charities_meta_box',
'title' => 'Charities Meta Box',
'pages' => array('charities'),
'context' => 'normal',
'fields' => array(),
'local_images' => false,
'use_with_theme' => get_template_directory_uri() . '/Tax-meta-class'
);

$charities_custom_meta = new Tax_Meta_Class($config);

$charities_custom_meta->addText('charity_home_page',array('name'=> 'Charity Home Page'));
$charities_custom_meta->addText('charity_facebook_page',array('name'=> 'Charity Facebook Page URL'));
$charities_custom_meta->addImage('image_field_id',array('name'=> 'Charity Logo '));
$charities_custom_meta->addFile('file_field_id',array('name'=> 'My File '));

$charities_custom_meta->Finish();

Javascript error in image uploader (debug mode) due to warning about undefined post index.

Put WP in debug mode by setting this in wp-config.php:
define('WP_DEBUG', true);

Using Firefox, create an image field and try to upload an image. A javascript error is thrown due to the following warning being written into the page:

<script type="text/javascript">post_id = Notice: Undefined index: post_id in D:\XXX\wp-admin\includes\media.php on line 1260 Uncaught SyntaxError: Unexpected token : 0;</script>

Error on image upload

Hi there and thanks for this plugin. I'm having trouble getting the image uploader to work. The media upload box opens. I'm able to select or upload an image, but after clicking the USE THIS IMAGE button the media upload box remains and blanks itself out... and there is a JS error as follows: TypeError:jQuery('img',html).attr('class') is undefined - referring to this line in the JS file "img_calsses = jQuery('img',html).attr('class').split(" ");" (line 294)

Thanks for your help....

Can't delete images, message alerts 'undefined'

When trying to delete an image I only get an alert saying 'undefined' and the image isn't removed.

Values not updating when moving servers

Hi,

I have just moved over my site from one server to another and the taxonomy meta didn't change for images.

I have looked in the wp_post_meta table and it's using relative paths however when using get_tax_meta() it uses the old URL when it I print out the [src] for an image.

I am using it as part of a theme and my using:

'use_with_theme' => true

Has anybody else encountered this?

Cheers,
Steve

'use with theme' option goes to stylesheet dir, rather than template dir

More of a suggestion than an issue, but if line 112 changed to this:

if ($meta_box['use_with_theme'] == true){
$this->SelfPath = get_template_directory_uri() . '/Tax-meta-class';

instead of

if ($meta_box['use_with_theme'] == true){
$this->SelfPath = get_stylesheet_directory_uri() . '/Tax-meta-class';

Then it works in nicer with child themes. As it stands you have to either copy the meta class folder to the child theme or specify the full path to the template folder.

Adding custom taxonomy with repeater block

Quick edit screen addFile not uploading

There seems to be no file uploading working from the Quick Edit/Creat screen when using the addFile function. Yet when you go into the full edit screen it works fine.

Is there a chance you could help me with this?
Here's a screenshot of the issue :)

New bug after issue #2 fixed

js/tax-meta-clss.js line 356

//fix issue #2
jQuery("#submit") should be jQuery("#addtag #submit")

Ohterwise the image will be deleted while editing a taxonomy

Taxonomy List Duplicated

require_once("Tax-meta-class/Tax-meta-class.php");
if (is_admin()){
    $prefix = 'st_';
    $config = array(
        'id'                => 'stanlux_metabox',
        'title'             => 'Stanlux',
        'pages'             => array('stanlux'),
        'context'           => 'normal',
        'fields'            => array(),
        'local_images'      => false,
        'use_with_theme'    => false
    );

    $my_meta =  new Tax_Meta_Class($config);

    $my_meta->addImage($prefix.'image_field_id',array('name'=> 'Banner da linha '));

    $my_meta->addTaxonomy($prefix.'taxonomy_field_id',array('taxonomy' => 'category'),array('name'=> 'Application '));

    $my_meta->Finish();
}

Hello, thanks for this plugin :)

Everything works ok but I'm having trouble when I try to edit taxonomy. The taxonomy metabox list is getting duplicated! This issue occurs only on edit page (edit-tags.php?action=edit)

If I save the changes all data are duplicated.