balance-io/balance-wallet

A mobile wallet for dapps & tokens.

balance-wallet's Issues

Balances - plug in the data

🔢Truncate crypto amounts at $0.01 precision

In the Balances tab, we should consider truncating crypto amounts when they surpass $0.01 precision (1 cent in native currency). In Transactions and when sending/converting you should probably see exact amounts.

When value = $xxxx.xx, .000001 is sufficient
When value = $xxx.xx, .00001
When value = $xx.xx, .0001
When value = $x.xx, .001
etc.

Maybe one additional decimal place? Ensure minimum of 2 decimal places when available?

WalletConnect connected states view (UI)

Shamelessly steal obscura’s onboarding flow

😇

Update and test Wallet Connect on Manager

I will take this on here: balance-io/balance-manager#265

Ability to copy seed phrase

I would like to be able to copy it and paste it into a secure place.

Is that OK for a small wallet?

Perhaps export to 1password?

Camera issue with iPhone held horizontally

🔂 Handling multiple activities

Sometimes dapps will send a signing and value transaction.

We can call these activities.

Hook up the hide assets with no values; sort assets with no values alphabetically

Chill on the ask for notifications access

from @vikmeup

Revoking camera access messes with UI

Overlaps text

📰 Add media and press kit to the about page

I want the /about page to be a place where people can see all of the videos, blog posts, photos and coverage of Balance. That way, anyone who is curious about the company—from journalists to potential employees—can get up to speed.

♻️Show people their backup phrase

Add this ability into the Settings page; minimally allow show/hide

QR code to display public wallet address in settings

Tap targets

Do a review

🏅Balance Wallet Alpha

We need to get a super basic version of Balance Wallet out in the wild ASAP.

Wallet
Generate wallet on startup
View Balances
View Transactions

Send
Design WIP by @christianbaroni

Scan
Connect to a walletconnect-enabled dapp

Settings
Design WIP by @christianbaroni

Sketch file: https://cl.ly/2R2L0L3M0i3G

Empty states in wallet

📱Slow internet checking

I was on 4G but the actual download speed was cripplingly slow so WalletConnect Just was not connecting.

📑Support for ERC-712 transaction information

https://twitter.com/0xproject/status/1006587684234584064?lang=en

https://eips.ethereum.org/EIPS/eip-712

This is really important.

Failed Transaction Registers as "Pending" and not "Failed"

So, two things actually:

1. Update your Augur contract, they migrated lol. I forgot about this when I sent the transaction.
2. Something is weird with the Pending modal when the transaction is failed (i.e. it should resolve to Failed, or "Sent" in red or something)

Check out this screenshot, it says the transaction is pending, but it was logged as failed and mined. This is still ongoing even as I write this issue, so it is definitely a bug. I refreshed the page, still same issue.

Etherscan transaction:
https://etherscan.io/tx/0xac1fce1887d5b122eb8dc048184c91bb7369abb5ec6195a14882d1a9dd3b8c3f

CoinMarketCap (or Nomics) for historical prices

❓Should we remove the BalanceWallet-tvOS scheme?

Splashscreen should stay open until all data loads. Then we can kill of LoadingScreen

Small phone layout fixes

Wallet Connect session management

Tab Menu Bar

Adding a menu to the bottom of the app would be nice.

Settings (currency, language)

• SettingsOverlay
  • Prevent swiping to other screens while SettingsOverlay is active
  • Background blur – must be able to animate the blur value
  • Background fade in, Overlay scale up from center starting at half-size
  • BackupSection – FaceID -> show Seed Phrase (https://files.slack.com/files-pri/T0DJ1LHK7-FDBPGHVSM/image_from_ios.jpg)
  • Match animations with default iOS transitions
  • Review urls (about, legal, feedback)

Push notification to just show the txn confirmation screen if you are already in the app

Send functionality

Native value on txn confirmation view

Wallet Connect transaction confirmation view

Push notifications and transactions to approve

• Use notification+data payload but fetch all transactions when push notification clicked and display notification that was clicked; also fetch all transactions when app first loaded; also fetch transactions intermittently (how to remove all notifications for those that have been fetched?)
• Remove transaction from transactions-to-approve queue only when approved or rejected
• Immediately show transaction details when in foreground and not already in approval state

🔏Code Signing

This is something that I think we should be very careful about. It is an important section of the fastlane toolchain.

I trust @jinchung to look at this and get this right:

Match Setup (Code Signing)
https://medium.com/react-native-training/fastlane-for-react-native-ios-android-app-devops-8ca85bee614e

⚠️ Intro screen / disclaimer

Scan button for Wallet Connect

🔛 Connext State Channel Integration

We want to make it possible for people to send payments to each other instantly and for free. State channel hubs can help this. I do not understand state channel hubs but the folks at Connext do.

Useful links:
https://medium.com/spankchain/a-state-channels-adventure-with-counterfactual-rick-part-1-ce68e16252ea
https://github.com/ConnextProject/connext-client
https://github.com/SpankChain/SpankCard

0.5 🔒 Privacy Policy

We need a clear page up at: balance.io/privacy

Putting this issue here as it is a blocker for the app getting submitted.

🤳QR code screen for WalletConnect Demo

Activity feed

• Transaction history segmented by Today/Yesterday/This Month/Month names
• Incoming WalletConnect requests
• fancy swipe interactions
• expanded transaction details

Security audit

Set up Fastlane Boarding

Make it simple for people to join the Beta: https://github.com/fastlane/boarding

Name of the token overlaps with the price of the token

Will post a screenshot.

Add support for test nets

Test net 🧟‍♂️🖲👍

📟 Yubikey Integration

https://www.yubico.com/products/yubikey-for-mobile/

Is this possible?

Manager - make Log Out only visible when actually logged in

Log out button to clear local storage on Manager once connected with WC (or any of the other wallets for that matter)

Create a page for testers

We should create a page for the people willing to test out Balance Wallet.

It could be:

balance.io/testers
testers.balance.io

Here is how to add a custom domain to our boarding app.

https://devcenter.heroku.com/articles/custom-domains

Graceful WalletConnect error states (i.e, when internet is choppy)

If push notification fails to send, retry or at least show a more specific error.

Create a separate data layer project

Reducers, helpers, handlers, parsers need to be a separate entity to be shared between wallet and Manager

📲Setting up fastlane and testflight > testing flow