balanced/balanced-ios

Balanced iOS

balanced-ios's Issues

Framework download area

We need a download location for pre-built versions of Balanced.framework so users can download it and drop it into their projects without having to build the project themselves.

Best Practices for initWithMarketplaceURI

It seems like storing a string literal of your marketplace URI on the client is a pretty big security risk (you could pull the string literal out of your binary). Are there any suggested best practices for this?

security code is not a required parameter

security_code is not a required parameter. Therefore, it probably should not be a parameter required when creating a Card. Leave it to be specified in optionalFields.

Xcode 5 Compatibility

Add Apple Pay integration

Add travis-ci support

It looks like Travis-ci supports building iOS libraries.

Let's implement a .travis yml file so that balanced-ios is built and tested on every commit.

Expose response status code

Should reflect new card creation parameters in api 1.1

https://github.com/balanced/balanced-ios/blob/1.0.1/Balanced/BPCard.h

Eg still shows security_code when rev1.1 accepts cvv

Reduce Friction in Collecting Card Info

Currently, there are 3 main ways to collect card information in the mobile context:

1. Card Reader (Square)
2. Type it in
3. Visually scan the card (card.io)

Card readers are hard, because no one has one. Square is very nice in sending them out for free, but if I'm an app developer, the hardware portion of distributing card scanners is way too much work. I'm not building it.

Typing it in is hard. There's a lot of characters, and a lot of different fields you need to fill in. This seems like a lot of friction, and a very large spot to lose users.

Visually scanning the card with something like card.io is a great idea, but completely flops in practice. I created a test app with card.io ( and tried out some apps that use it ), and it actually took me just as long to get the card to scan as it does to type it in. And then I still had to type in the expiration date, name, and CVC.

---

This isn't actually an issue with balanced, or with the balanced-ios library, but it is an issue for me as I consider making apps that would leverage balanced. I've probably gone through 3 app ideas in the last month that would have used balanced, and gave up on them because I decided there was too much friction in entering card info. Just a thought, and it seems like balanced is someone who would be interested in this.

BPUtilities queryStringFromParameters causing EXC_BAD_ACCESS

Not sure how the memory issue was happening, but the following fixed the issue with this pull request: #17

+ (NSString *)queryStringFromParameters:(NSDictionary *)params {
    NSMutableString *queryString = [NSMutableString string];
    [params enumerateKeysAndObjectsUsingBlock:^(id key, id obj, BOOL *stop) {
        NSString* contentToAppend = [NSString stringWithFormat: @"&%@=%@", obj, key];
        [queryString appendString:contentToAppend];
    }];
    return queryString;
}

Update for Balanced API 1.1

Is there a way to build a target-agnostic version of Balanced.framework

From a customer:

The balanced-ios project builds Balanced.framework Library for a specific target (simulator or device).

I can choose to build the framework for the simulator and add it to my project to run on the simulator.

Then if I need to build my app on a device I need to:

• Delete the existing Balanced.framework from my project
• Rebuild balanced-ios for a device
• Add the built Balanced.framework back to my project.

Then I have to do the same process to go back to building against the simulator.

Is there a way to build a target-agnostic version of Balanced.framework? Or a way to build both and have it decide at runtime which version to use?

Unable to compile framework

Checking this out there's no Balanced.framework folder, and attempting to build brings up the error: "target specifies product type 'com.apple.product-type.framework.static', but there's no such product type for the 'iphoneos' platform"

thank you

Card tokenization doesn't include security code

Self explanatory.

Huge issues. We had multiple card failures when customers tried to tokenize cards. Kind of took it for granted that this would have been in the library from the get go.

Static Library

The framework approach that's currently being used in balanced-ios is cumbersome and has proven to be a barrier for new contributors. It also completely blocks any hope of testing with travis-ci since the project requires the installation of Xcode templates for the project to compile correctly.

I've rebuilt the project to compile a static library and the changes can be found in the staticlib branch. To use it, balanced.a and the headers must be copied into iOS projects. I soon discovered there is a bug when running tests from the command line. SSL requests fail with and invalid certificate error, but the same tests pass when run from within Xcode. I've implemented a macro to disable certificate checking only for command line test runs.

I'd like feedback on the following:

• Ensure certificate checking is in fact happening in all builds of the library other than the command line
• Ensure the static library works in both simulator and device runs of iOS projects
• Any other issues overlooked during the conversion to building a static library

Address fields are no longer top-level

Address fields in API 1.1 are not top-level. Update the README to demonstrate the use of supplying an address object in the optional fields. https://gist.github.com/remear/5c84f551aa552b358d0f

Update payload to include same fields as balanced.js

Build Issue

We received this from a customer:

The iOS repo: https://github.com/balanced/balanced-ios is failing to build.
I get the following error:

Target specifies product type
'com.apple.product-type.framework.static', but there's no such product type
for the 'iphonesimulator' platform

XCTest

http://iosunittesting.com/xctest-first-impressions/

Pod spec for version 1.0.1

Could you please add a pod spec file for current version 1.0.1 in https://github.com/CocoaPods/Specs/tree/master/Specs/balanced-ios ?
Thanks~