bapairaew / open-fpl Goto Github PK
View Code? Open in Web Editor NEWOpen-source Fantasy Premier League tools
Home Page: https://openfpl.com
Open-source Fantasy Premier League tools
Home Page: https://openfpl.com
Currently we have
interface Preference {
name?: string; // Profile name
teamPlannerPinnedBench?: boolean; // If team planner's bench section always visible
playersExplorerDisplayOption?: DisplayOptions; // Display options for players explorer
playersExplorerSortOption?: SortOptions; // Sort options for players explorer
playersExplorerTableSortColumns?: PlayerTableSortColumnConfig[]; // Sort columns for table view players explorer
}
interface Settings {
preference: Preference | null; // Profile preference
teamPlans: string[] | null; // List of active profile's team plans
fixturesTeamsOrder: string[] | null; // Fixtures page row order (shared)
starredPlayers: number[] | null; // List of starred players (shared)
customPlayers: CustomPlayer[] | null; // List of custom players (shared)
teamsStrength: TeamStrength[] | null; // Overridden teams strenth adjustment (shared)
// ...
}
Many of these do not make sense. Everything should be shared across all profiles but name and team plans.
As an Open FPL user, I would like to see my customised attack/defence home/away based FDR on other pages, so that I can actually make use of the customisation I provided and make a better decision.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Open FPL logo stays still
There is a couple seconds lag when scrolls up/down the table view in Players Explorer and Team Planner's transfer market which makes browsing experience not pleasant.
Some info are more relevant than others for some players. Disallowing customisation implies that there is only one set of data that is better than others while in fact there are more ways to play the game. So we should allow users to pick what data they think it is more relevant.
Once there are enough tabs to fit the width of the screen, the tab content would started to be wrapped into multiple lines of text. This would result distortion in the UI.
There is no indications that table cells are clickable to show team strength chart/team power level comparison. Would be nice if we could provide a visual to let the users know that there is a feature hidden there without disrupting the current look and feel.
At some point, HTML semantic were completely neglected and this ended up in quite a mess. In order to play nice with SEO, bots, and screen reader and for the sake of a11y. Please have a revisit on the whole application HTML semantic.
Some points you might want to start looking at
Awesome project btw, thank you.
Just wondering which open-source license is, or would, your code base be under? You do not specify a LICENSE
file at the root of your project.
May we assume that your source code not being private suggests that it may be used, freely, elsewhere?
If so, might I suggest you choose a license from the list found here?
You could simply copy and paste a suitable license from https://choosealicense.com/licenses/mit.
Also, there are several tools that can aid you in evaluating the current licensing of the libraries and dependencies that are being used within your project, for compliance. Here are a few examples of such software (no particular order):
https://github.com/lirantal/licenseye
https://github.com/mwittig/npm-license-crawler
TBD
Goalkeeper points rely heavily on their number of shot saves and clean sheets. Currently, Open FPL only provides only xGA which is not enough for managers to make a decision.
Some teams have to the same colour codes (e.g. MUN and LIV) which makes it harder for user to distinguish them at a glance. The colour codes are current extracted from https://teamcolorcodes.com/soccer/premier-league-color-codes/ which is introduced this issue and moreover the data is. already outdated.
Might be better to just hard code these values base on their current year kit colour since they are changed only once a year.
Also somewhat related issue: dark mode was disabled because FPL colour codes and team colour codes worked quite baldly with base Chakra UI dark theme. Since FPL colour codes should be simple to adjust so once team colour is fixed this should be very trivial to fix. If not, create another issue to enable the dark mode.
The current data refresh mechanism is relying on a GitHub action that will commit a change on ./packages/data/last-updated.json
which subsequently trigger auto deployment on Vercel. However, it is not guaranteed that open-fpl-data project would be deployed before open-fpl project, hence, this would result open-fpl refreshed with outdated data from the day before.
I goto https://app.openfpl.com
I setup profile successfully (it gets my team name and rank etc)
I goto Team Planner and i get an error
_"Uh oh, something went wrong.
To be honest, we are not too sure what happened so please tell us what you did on Github
or Twitter."_
OS: w10 19045
Browsers: Edge 108.0.1462.54; Chrome 108.0.5359.125; Firefox 107.0.1
OS Android 12
Browsers: Firefox 108.1.0 and Chrome 108.0.5359.128
It worked fine last season but hasnt worked at all this season. I tried removing 2fa auth from my profile and deleted all browsing data from chrome
https://i.imgur.com/bntsFjs.png
edit: the players explorer page appears to be from last year. no haaland, no alvarez, nunnez etc. Origi is still a LIV player. Same on mobile and Desktop. Fixtures for current gameweek are dated 06/05/23 but are totally wrong e.g Brentford v Chelsea, Burnley v Everton.
As a FPL manager, I would like to sort teams by FDR of multiple gameweeks, so that I know which teams/players would more like yield better returns in a longer term.
Their cheapest plan is cheaper than https://usefathom.com but capped at only 10k page views monthly. Their features seem to be very comparable; Plausible seems to have cleaner integration with Next.js (https://github.com/4lejandrito/next-plausible) . So needs to find out about Plausible dashboard performance and usability.
Based on current stats, our page views are at 5k in 3 days, so we are looking at optimistically 50k page views monthly. Price at 100k is very close but Plausible would be cheaper if we are under 10k a month.
Plausible is offering - $6 for 10k, $12 for 100k, $20 for 200k, $30 for 500k, ...
Fa is offering - $14 for 100k, $24 for 200k, $34 for 400k
The current architecture relies mostly on static data which is only updated once a day. It is done this way because of two main reasons: limit workload on data sources side (Official FPL and Understat), and limit workload on Open FPL side since ultimately it aims to be lifetime free-to-use so minimising all costs possible would make Open FPL more sustainable in long term.
This, however, comes with a few unfavourable experience as users would have to wait until next update to get the latest data.
Lack of live data has a major impact on Team Planner feature since the user would not be able to get their latest team after the deadline has passed which usually happens hours before scheduled data updates. Another minor impact includes - player points data would not be updated until the next data sync.
There is a quick workaround by increasing the frequency of the data sync but that will not only increase unnecessary workload to sources but also could end up very expensive of our side since there is limit of both GitHub actions and Vercel deployment we can do without blowing the budget. Also there is a doubt that how much improvement this would be since there is a chance that the users have to wait until the next data sync which could be minutes, hours, or whatever our new sync frequency is.
Not only "Live" data architecture should fix the issues above but also would unlock features like Live Ranking, Live Score, Live Dashboard which should be very useful and enticing features to the users as it will help them enjoy the live game more.
As an app developer, I would like to know how the app is being used, so that I can make improve current features, and design new features based on real life data.
Stats show that around 50% of the traffic are using phone to access Open FPL and currently Open FPL does not support those devices screen yet.
We are providing a link (https://fpl.team/find-id) to show the users how to find their FPL team ID. The instruction does not seem to applicable for official FPL preseason UI. So either update the link, provide our own instruction, or find a crazy way to make it easier to get the team ID.
Current search query does not support a simple use case where a user want to look for a player below a certain price. The current workaround is to use 0-XX range search which is not obvious to figure out.
Maybe use this lib instead: https://github.com/GitbookIO/filterable.
Describe the bug
Lineup section in Team Planner page got cut off in Safari 12.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Lineup section in Team Planner is shown in page
Desktop (please complete the following information):
Additional context
Other pages work fine
Adding profile with invalid team ID results a successful profile creation.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Error or warning is shown to tell the users that the team data would not be synced with FPL if they decide to proceed.
Currently, outdated team plan transactions will be highlighted as outdated once the relevant gameweek has passed. This requires users to manually remove them from their plans. The experience would be more seamless if those transactions were removed automatically once become irrelevant.
People are linking to https://www.openfpl.com/players directly which is not really a nice URL.
Open FPL aims to provide only relevant stats to its users without overwhelming them. General stats should give a manager enough information, at one glance, to make a decision if they want put certain players to their team OR to shortlist a group of players for further research on other websites.
Current assumption is that player form is the king so Open FPL provides stats from last 5 matches along with seasonal stats for baseline comparison. This assumption could be wrong so please have a revisit on this after getting enough feedback.
Note:
Other stats that might be useful: VAMP
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.