barttc/django-frontendadmin

Not in active development; see README -- django-frontendadmin is a set of templatetags to allow an easy and unobstrusive way to edit model-data in the frontend of your page. See wiki for screencast!

django-frontendadmin's Issues

SSL/Https in action_url

I noticed that you used request.build_absolute_uri() for the action_url in change delete etc. This always seems to resolve to http: so it leads to security warning or worse SSL enabled sites. Why not use request.get_full_path ??

spelling error in views.py

in playing with the current tip, found a spelling error in views.py, line 160:

         # Return to last page
         if request.is_ajax():
             return success(request)

     return _handle_repsonse(request, instance)

Danish locale file

I created a Danish locale file for the project. The django.po file can be found here:

http://www.daimi.au.dk/~illio/pinax/frontendadmin/django.po

Exception on add, create, delete for versions < Django 1.4

Exception Value: create() takes exactly 1 argument (2 given)

Introduced in the fix for issue#18 My bad!!

The code is

 request.user.message_set.create(msg)

But it should be:

 request.user.message_set.create(message=msg)

Change in add(),change() and delete() methods

Screencast is gone

Please reupload
http://static.mahner.org/video/frontendadmin.ogg

Wrong parameter lookup in POST querydict of _handle_cancel

The POST querydict does not get '_cancel' as a key in _handle_cancel but the key is 'submit' and value is '_cancel'. Due to this clicking on cancel on a form won't work (this is just one of the reasons, there is another reason which would require another topic to be opened).

Check http://github.com/theju/django-frontendadmin/commit/9768d968651c1237cf5def579d524eb926e4e5b8

1.2 Support - CSRF

One change for 1.2 support for CSRF is adding this within the <form> element of form_ajax.html:
{% csrf_token %}

AtributeError exception on add,change or delete actions in Django 1.4

Django 1.4 removed the message_set related manager from
the User model and also the message_set.create() method which was
being used to create the success messages. My suggestion to ensure compatibility with earlier versions of Django is to use a try block to trap the AttributeError exception that could be raised when message_set.create() is used.
If this exception is raised then the messages framework to create the success message

Can't use with non-ascii uri

Error happens in views.py on these lines:

return HttpResponseRedirect(request.GET.get('next'))

Works this way:

return HttpResponseRedirect(iri_to_uri(request.GET.get('next')))

Raise "No module named defaults" under Django 1.8

I've changed:
from django.conf.urls.defaults import *
in urls.py to:
from django.conf.urls import patterns, url, include
to see whether it's OK.

Proxy support

The app redirects to http://localhost:7999/frontendadmin/change/art/artwork/1163/?next=/art/1163/

Instead of using the proxy address. Why not rely on current site or even just redirect to an absolute path ?

form.serialize() does not serialize submit buttons

form.serialize() in form_ajax.html does not serialize the form atleast with jQuery 1.3.2. It has to be manually done.

Also HttpResponseRedirects get added into the current DOM (This is not handled in the current ticket but have handled it at work and would be willing to discuss).

Check http://github.com/theju/django-frontendadmin/commit/84e4949446aad94082ce05f6458d8bc75799a0d3

Integration with django-reversion

Modification done via Frontend Admin don't seem to show up in django-reversion history.