basf / metis-gui Goto Github PK

View Code? Open in Web Editor NEW

8.0 3.0 5.0 5.01 MB

Modular standalone fat-client GUI for X-ray diffraction data simulations, analysis, and sharing

License: BSD 3-Clause "New" or "Revised" License

JavaScript 6.48% Svelte 58.82% TypeScript 29.86% HTML 0.68% Shell 0.64% SCSS 2.93% Dockerfile 0.59%

svelte sveltejs optimade optimade-api

metis-gui's People

Contributors

Stargazers

Watchers

Forkers

paulmaly pyoner knopki tilde-lab glistenstar luckylionheart

metis-gui's Issues

Bad DTO

metis-gui/src/types/dto.d.ts

Line 31 in 378bfde

progress: number;

the progress field should be on the calculations, not on the datasources

Edit tags context command is broken

"Submit" button is always inactive.

NPM commands fail with the permission denied error, even for root

npm ERR! code EACCES
npm ERR! syscall scandir
npm ERR! path /root/.npm/_logs
npm ERR! errno -13
npm ERR! 
npm ERR! Your cache folder contains root-owned files, due to a bug in
npm ERR! previous versions of npm which has since been addressed.
npm ERR! 
npm ERR! To permanently fix this problem, please run:
npm ERR!   sudo chown -R 1000:1001 "/root/.npm"
glob error { [Error: EACCES: permission denied, scandir '/root/.npm/_logs']
  errno: -13,
  code: 'EACCES',
  syscall: 'scandir',
  path: '/root/.npm/_logs' }

HOW TO FIX: chown -r root bscience-gui

Router is broken on going back from user profile (/profile)

A known problem, caused by the pathfinder router: double clicking on an arrow ⬅️ is required.

Fix font color detection based on the background in the autocomplete component

Fix font color detection based on the background in the autocomplete component, see https://github.com/basf/metis-gui/blob/master/src/helpers/style.ts (does not work as expected)

Fix code scanning alert - DOM text reinterpreted as HTML

Tracking issue for:

https://github.com/basf/bscience-gui/security/code-scanning/2

@Valexr should we simply ignore it?

Datasources page: collections are not updated on the fly

The datasources are updated on the fly, but the collections aren't.

Fix an offline GUI warning that does not consider offline BFF

Fix an offline GUI warning that does not consider offline BFF, see

metis-gui/src/layouts/Overlay.svelte

Line 2 in 822fd5e

    
           <slot>Connecting to server...</slot><!-- FIXME (1) not GUI offline, but BFF offline (2) splash screen -->

Filtering collections and fallback to no results with Nodes layout

The src/pages/Materials and src/pages/Tasks use svelte:fragment filtering, but do not account for the case with no matches (just an empty layout will be shown).

Log in form error: always "You are logged in"

whatever creds are used, the same success toast is shown

Nginx config prevents BFF from proxying the request with the route inside /v0

TODO: this is bad and should be fixed asap.

Originally posted by @blokhin in #18 (comment)

Missing font color

See #96 (comment)

metis-gui/src/views/modals/TagsEdit.svelte

Line 32 in 4d62229

style: `background: ${collection.typeFlavor} !important`,

Repo transfer timeout

Hi @blokhin ,
Unfortunately I was too late to accept the repo transfers. Can you trigger them again?
Best,
Siggi

Fix an erroneous message "New version of this software available" which appears every minute (but no new version)

Fix an erroneous message "New version of this software available" which appears every minute (but no new version), see

metis-gui/src/views/Msgbar.svelte

Line 5 in 409f062

New version of this software available, click to update

Problem with docker

After building docker, an error occurs when running the 'metis-gui' image :
'sed: read error on /srv/index_html.orig: Is a directory'.

This is all the description of the error, I can’t figure out where it’s happening.

FilterPanel component is not configurable

@pyoner please, see our chat

Main menu should be fixed (sticky)

The main problem is that the pagination disappears after scrolling if too much data available.

Remove the caption "Log in with:" on a login screen if no icon providers have been set

Remove the caption "Log in with:" on a login screen if no icon providers have been set, see

metis-gui/src/config.ts

Line 34 in 822fd5e

    
           export const IdPs = ['basf']; // available: mpds, github, linkedin, orcid, basf, local

Edit calculation input form is broken and lacks important functionality

switching between the options does not work properly + there should be tabs for each kind of inputs supported by an engine

Leaking architecture: calling webhooks from GUI, mixing the logics of pagination vs. scheduler updates 😢

These are very bad things:

metis-gui/src/services/api.ts

Line 67 in 78a797d

postJSON(`/webhooks/calc_update${query}`, {})

https://github.com/basf/metis-bff/blob/6b86943a8d2c7310b82fcd9a332d44da503556ab/routes/%5Bversion%5D/webhooks/calc_update.js#L21

we have to refactor this at our earliest convenience...

FYI @pyoner @knopki

Selector width is broken

metis-gui/src/pages/Search.svelte

Lines 20 to 27 in 00a8d51

    
           <AsyncSelect 
        
           	data={$providersAsync} 
        
           	getOptions={providersOptions} 
        
           	value={$query.params.provider} 
        
           	name="provider" 
        
           	{size} 
        
           	on:change={submitOnChange} 
        
           />

	<AsyncSelect
	data={$providersAsync}
	getOptions={providersOptions}
	value={$query.params.provider}
	name="provider"
	{size}
	on:change={submitOnChange}
	/>