BLR-1Gb LA hardpoint lacking model

[PainGod85]

BLR-1Gb LA hardpoint lacking model

[CptMoore]

01:10.209 [WARN ] MechEngineer error processing hardpoint data for chassisdef_battlemaster_BLR-1GB at LeftArm: index=0 weapons=[chrPrfWeap_battlemaster_leftarm_ac20_bh1, chrPrfWeap_battlemaster_leftarm_ac5_bh1, chrPrfWeap_battlemaster_leftarm_flamer_eh1, chrPrfWeap_battlemaster_leftarm_gauss_bh1, chrPrfWeap_battlemaster_leftarm_laser_eh1, chrPrfWeap_battlemaster_leftarm_lbx_bh1, chrPrfWeap_battlemaster_leftarm_lrm15_mh1, chrPrfWeap_battlemaster_leftarm_mg_ah1, chrPrfWeap_battlemaster_leftarm_mg_bh1, chrPrfWeap_battlemaster_leftarm_narc_mh1, chrPrfWeap_battlemaster_leftarm_ppc_eh1, chrPrfWeap_battlemaster_leftarm_srm2_mh1, chrPrfWeap_battlemaster_leftarm_srm4_mh1, chrPrfWeap_battlemaster_leftarm_srm6_mh1, chrPrfWeap_battlemaster_leftarm_uac5_bh1] Exception: System.ArgumentException: An item with the same key has already been added. Key: mg
at System.Collections.Generic.Dictionary2[TKey,TValue].TryInsert (TKey key, TValue value, System.Collections.Generic.InsertionBehavior behavior) [0x000c1] in <d7ac571ca2d04b2f981d0d886fa067cf>:0 at System.Collections.Generic.Dictionary2[TKey,TValue].Add (TKey key, TValue value) [0x00000] in :0
at System.Linq.Enumerable.ToDictionary[TSource,TKey] (System.Collections.Generic.IEnumerable1[T] source, System.Func2[T,TResult] keySelector, System.Collections.Generic.IEqualityComparer1[T] comparer) [0x00085] in <1b13ba6391c74847bbc3eddc86df7eee>:0 at System.Linq.Enumerable.ToDictionary[TSource,TKey] (System.Collections.Generic.IEnumerable1[T] source, System.Func2[T,TResult] keySelector) [0x00000] in <1b13ba6391c74847bbc3eddc86df7eee>:0 at MechEngineer.Features.HardpointFix.prefab.PrefabSet..ctor (System.Int32 index, System.Collections.Generic.IEnumerable1[T] prefabs) [0x0002b] in :0
at MechEngineer.Features.HardpointFix.utils.WeaponComponentPrefabCalculator.GetAvailablePrefabSetsForLocation (BattleTech.ChassisLocations location) [0x0007a] in :0

[CptMoore]

"chrPrfWeap_battlemaster_leftarm_mg_ah1",
"chrPrfWeap_battlemaster_leftarm_mg_bh1",

both in same group, I'll just make an advanced json merge patch that revmoes the bh as the ah variants are used more often on the battlemaster. (only the highlander also has one ah variant, no other mech uses the mg ah variant).

[PainGod85]

So wait, what was even the issue? I'm not at all familiar with how the game calls weapon models.

[CptMoore]

I have an (implicit) check in place in case model hardpoint mapping on a mech is not unique (like there are 2 different prefabs/models that could be added to a mech in case you mount an mg). I then skip the location that is faulty in the mech and print out the error that happens with the unique check.

My fix is to just modify the config to only contain one entry instead of two. While I could automate the process in code, it does help with fixing bad hardpoint definitions (also for RT etc.).