Giter Site home page Giter Site logo

rules_angular's People

Contributors

alexeagle avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

rules_angular's Issues

Generated NgFactories have incorrect imports

See repro here: https://github.com/vsavkin/ng_module_issue_repro.

  • Run npm install
  • Run bazel build :ng_libs
  • Run bazel build //src
  • Open bazel-bin/src/app.component.ngfactory.js and you will see this import import * as i0 from "@angular/core"; It is correct.
  • Open bazel-bin/src/app.module.ngfactory.js and you will see this:
import * as i0 from "@angular/core";
import * as i1 from "./app.module";
import * as i2 from "./app.component";
import * as i3 from "./app.component.ngfactory";
import * as i4 from "@angular/core/core";
import * as i5 from "@angular/common/common";
import * as i6 from "@angular/platform-browser/platform-browser";

"@angular/core/core", "@angular/common/common", and "@angular/platform-browser/platform-browser" are incorrect. They should be "@angular/core". Running NGC creates factory files with correct imports

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.