bazzline/php_component_locator_generator

free as in freedom free software php locator generator component to easy up locator generation

php_component_locator_generator's Issues

generate locator has to implement "LocatorInterface" if at least one "is_factory" is true

If you add a "is_factory" => true, you get the following error.

Argument 1 passed to BlaBlaFactory::setLocator() must be an instance of Net\Bazzline\Component\Locator\LocatorInterface, instance of BlaBlaLocator given

Whenever "is_factory" is configure to "true", the "implements" configuration section has to be extended by "Net\Bazzline\Component\Locator\LocatorInterface" automatically.

FromPropelSchemaXmlAssembler creates invalid configuration when used with namespace schema xml

Take a look at FromPropelSchemaXmlAssemblerTest::testAssembleWithValidAllData().
The Expectation is "My\Tables\One\MyTableOne" but should be "\My\Tables\One\MyTableOne".

Add "\Net\Bazzline\Component\Locator\LocatorInterface" to use if it is implemented

Unneccesarry fully qualified name

DeleteStrategy not working as expected

File is removed but error "file ... already exists" is outputted.

Is this still needed?

@tworzenieweb is this still needed?

Else I would put it in archived mode.

last entry in "class_name" is used everywhere to generate new instance

example generated locator

//....

    /**
     * @return \Net\Bazzline\Component\Cli\Arguments\Arguments
     */
    public function getCliArguments()
    {
        return $this->fetchFromSharedInstancePool('\Net\Bazzline\Component\CommandCollection\Filesystem\Remove');
    }

    /**
     * @return \Net\Bazzline\Component\ApiDocumentBuilder\Builder\Apigen
     */
    public function getApigenBuilder()
    {
        return $this->fetchFromSharedInstancePool('\Net\Bazzline\Component\CommandCollection\Filesystem\Remove');
    }
//...

FactoryInterface not added in "use" when configuration option "'is_factory' => true," is set

    'instances' => array(
        array(
           //...
            'is_factory'    => true,

Configuration above does not adds the "use Net\Bazzline\Component\Locator\FactoryInterface" to the generated locator

add compatibility to the container-interop interface

https://github.com/container-interop/container-interop/blob/master/src/Interop/Container/ContainerInterface.php

method "isNotInFactoryInstancePool" and "addToFactoryInstancePool" are not created if configuration is set to "'is_factory' => false,"

    'instances' => array(
        array(
            //...
            'is_factory'    => false,
            'is_shared'     => true,

Configuration above will generate locator method like:

    final protected function fetchFromSharedInstancePool($className)
    {
        if ($this->isNotInFactoryInstancePool($className)) {
            if (!class_exists($className)) {
                throw new InvalidArgumentException(
                    'class "' . $className . '" does not exist'
                );
            }

            $instance = new $className();
            $this->addToFactoryInstancePool($className, $instance);
        }

        return $this->getFromSharedInstancePool($className);
    }

'addToSharedInstancePool' and 'isNotInSharedInstancePool' should be used.