including in webpack build

[bbglab]

including in webpack build

[mpschr]

Hi @acthp

I have never used webpack and don't know what may be causing the problem. Does webpack also use the package.json file to install dependencies?

[acthp]

Yes, webpack uses npm and require(). The problem is that muts-needle-plot uses a combination of require() , and global variables, with d3, underscore, and d3-svg-legend being loaded as globals, but others being loaded with require(). I eventually worked out a solution using webpack's shims for legacy modules. Like this:

// The next three are required for muts-needle-plot.
{ test: /d3-svg-legend/, loader: "imports?d3=d3" },
{ test: /muts-needle-plot/, loader: "imports?_=underscore" },
// The d3-tip AMD loader does not populate d3.tip, which is expected
// by muts-needle-plot. So, we disable it here. The CommonJS loader
// will populate d3.tip.
{ test: /d3-tip/, loader: "imports?define=>false" },

and also doing an explicit require() for d3-svg-legend. The 'imports' loader injects a binding into a module that is expecting a global variable.

If you don't want to directly require() some dependencies, e.g. so the user can override them, you can parameterize the lib with the dependencies. Like change the globals to parameters on the constructor, or on an 'initialize' routine.

[mpschr]

Ok, thanks for the info and glad you could manage it, @acthp.

The above line you have added to the package.json? Please feel free to make a fork and add you changes.

Also if you know very well which changes to make to muts-needle-plot I would appreciate a patch since in this moment I don't see time to tackle this issue and it wuold help you clean up the code in your project.

Best