Comments (3)
I meant the underlying "driver" for the adapter. That way bamboo benefits from the latest improvements in the API and their client libraries (less maintenance work for you).
from bamboo.
@stevedomin I thought about doing that, but decided against it for a couple of reasons
- If you want to update just the Mandrill dependency in your app, but Bamboo hasn't been updated, you could have conflicts and have to override the mandrill version, which might cause issues. Or if you update Bamboo and it requires a new version of Mandrill, you may not want to update the rest of your app to use the new version of the Mandrill package.
- The actual implementation for sending emails is pretty small: https://github.com/paulcsmith/bamboo/blob/master/lib/bamboo/adapters/mandrill_adapter.ex#L6-L34 Most of those lines are for the error message.
- The Mandrill package includes a ton of extra functions that Bamboo doesn't really use or need.
So in the end, I don't think maintaining it in Bamboo will be hard, and will likely be better for end users since they won't have to worry about Mandrill version mismatches.
What do you think?
from bamboo.
Chatted on Slack. I may move adapters out of Bamboo core, but for now I'll keep them here for simplicity
from bamboo.
Related Issues (20)
- Bamboo.SentEmailViewerPlug with SendGrid Dyanmic Templates
- defimpl for maps
- Failed to use "mime" because HOT 5
- How to implement or configure a sending rate limit?
- How to implement DKIM HOT 1
- Assertions are destructive
- SentEmailViewerPlug shows empty emails with Dynamic Templates & LocalAdapter
- SendGrid's root level custom_args is currently unsupported HOT 1
- Mime Version Conflict HOT 2
- FQDN/hostname isn't getting passed or set correctly
- NilRecipientsError thrown incorrectly for SendGrid emails
- `dynamic_template_data` getting ignored for individual personalization in SendGrid
- Fix Regex match failure on `refute_email_delivered_with/2`
- Sending errors lead to argument errors
- There is no way to disable subscription_tracking in SendGrid adapter
- Support for Sendgrid's `reply_to_list`
- [Proposal] Add Optional Callback for User, to load existing sent emails.
- assert_email_delivered_with has verbose failure output
- incorrect typespec in Adapter behavior HOT 12
- deliver_later spec
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bamboo.