beamapp/musicplayerviewcontroller

An iPhone view controller to visualize and control music playback

musicplayerviewcontroller's Issues

test BeamMusicPlayerViewControllerTests#testPlaylistVisibility fails on iPad

As @DerPipo describes in #14 by the aforementioned tests fails on iPad. Also, it should be ensured that travis runs tests on iPhone and iPad.

Does this music player work with restful APIs

Hi All,

I am trying to make song app. I am getting songs via restful APIs. Can anyone tell me this music player work with htttp request and response?

Thanks.
simerpreet

Cannot launch example project

When I try to launch the example project I get many errors (xcode stops counting at 20)

In BeamMusicPlayerViewController.h:

I can fix the errors by inserting a { after
@interface BeamMusicPlayerViewController : UIViewController

In OBSlider.h:
/MusicPlayerViewController-master/Pods/Headers/OBSlider/OBSlider.h:1:1: Expected identifier or '('

I cannot fix this error.

fix: rendering on next major iOS version

in general:

• offset of view (and subsequently navigation bar, scrubbing area, etc.)
• tinting of buttons

on iPad:

• background color of popover when presenting playlist

Missing playlist function !

Hi,
I found that on the version on github is already have playlist function,but for the version on pods is not yet done.

Could you update please ?
Thank you in advance !

Add option to change audio route

Right now it isn't possible to change the audio route.

Using MPVolumeView instead of a custom UISlider in combination with the delegate methods would fix this.

overhaul license info in file headers

explicitly refer to the actual license name in each file

notify delegate if end of a play list is reached

Whenever the user skips before the first or behind the last track, or if the player finishes the last track of a playlist the delegate should be informed to perform further actions like displaying an album picker.

No Audio in Example?

I have found that I am unable to play audio in the example project using xCode 5. In all places. Any recommendations?

Podspec omits the xib

When using the BeamMusicPlayerViewController via the pod spec, it doesn't display at all, because the xib is not part of it. I am just getting started with CocoaPods, so unfortunately I cannot provide a bugfix for this myself. Workaround: download the xib manually and add it to the app project.

help needed

Dear Developer, can you help me change the url to a stream url instead of preview url

transition when changing album art

when changing the album art, a slide transition would improve the the UX. To avoid pixel-based comparisons or unneeded server-roundtrips, another delegate method should answer the question if the album art, is different between two tracks.

automatic skipping when track reaches end

currently, in [BeamMusicPlayerViewController currentTrackFinished] there's a call to [self next] commented out. This is fine if the underlying music player informs the view controller about an ended track. One should be able to re-enable the behavior for other implementations of the music player.

skip to the beginning of current track

Similiar to other interfaces, the player should skip to the beginning of the current track if the current playback position is > 3 seconds. Only if current playbck position is <= 3 seconds it should skip to the previous song.

Add internationalization

These strings are hardcoded:

• "Track %d of %d"
• "Hi-Speed Scrubbing"
• "Half-Speed Scrubbing"
• "Quarter-Speed Scrubbing"
• "Fine Scrubbing"

I don't know what's the best way to do this, but i think adding I18N to the bundle would be a nice one. Then we could use NSLocalizedStringFromTableInBundle(...). By adding a NSBundle property to the view controller also the resource loading would be better, because if the bundle name changes you only need to modify one line of code.

BeamMusicPlayerExample crashes on launch on iPad running iOS 5.1.1 (9B206)

The issue is that in Source/BeamMusicPlayerViewController.m : viewDidLoad, the calls to setVolumeThumbImage:forState:, setMinimumVolumeSliderImage:forState:, setMaximumVolumeSliderImage:forState: are only NS_AVAILABLE_IOS(6_0).

Because the iOS deployment target is 5.0, there should be a runtime check that MPVolumeView instancesRespondToSelector:, to avoid crashes on and to properly support an iOS 5.0.

smart flat design with derived color schemes

https://github.com/fleitz/ColorArt
http://imgur.com/a/G9aRO