beapi/meta-for-taxonomies

A WordPress plugin for add metadata API for term/taxonomy

meta-for-taxonomies's Issues

Function name clashes with WordPress 4.4

Hi there.

Here what I spotted so far: update_termmeta_cache(), add_term_meta(), delete_term_meta(), get_term_meta() and update_term_meta().
But the worst part is that we also have non-matching function signatures: the plugin functions use $taxonomy as first parameter, but WordPress doesn't.

Cache group used in wp_cache_* functions should be 'term_taxo_meta' not 'term_taxometa'

update_termmeta_cache uses a $meta_type of 'term_taxo' when it calls update_meta_cache. In update_meta_cache, it appends '_meta' to the $meta_type to generate the $cache_key, loading everything into the 'term_taxo_meta' cache group.

The plugin has a number of calls to wp_cache_set, wp_cache_get, and wp_cache_delete all using 'term_taxometa'. I noticed it by trying to use get_term_custom and backtracking when it wasn't getting values I could see in the database it was saving.

Doesn't seem to affect retrieving single term meta values with get_term_meta since that is using the core get_metadata function that handles appending the correct '_meta' string to the $meta_type.

Clash in function naming: `add_term_meta` with All in One SEO Pack Pro

Hello! I thought you would be interested in this curious issue. Along the course of my work, I found that there is a clash in the name of function add_term_meta with All in One SEO Pack Pro while evaluating Taxonomy Thumbnail (which depends on this plugin optionally) and AIOSEOP Pro at the same time.

It appears that the function has yet to be used by AIOSEOP Pro for now, as I could not find any invocation of the function yet. Since the function has yet to be released in the free version, I think the most I can share offhand is the arguments list:

function add_term_meta( $term_id, $meta_key, $meta_value, $unique = false ) { ... }

Purge meta cache with term cache

Implement purge cache of term metadata on follow hook : clean_term_cache

Bug avec get_term_id_from_meta

Quand on veut récupérer un terme à partir de sa valeur dans une taxonomie, la fonction get_term_id_from_meta ne renvoie pas la bonne valeur si la valeur recherchée est dans plusieurs termes.
Cela vient du fait que la fonction get_term_taxonomy_id_from_meta ne prend pas en compte la taxonomie.