beetee17/ped

ped's Issues

Deleting a Tag does not update the separate panel

For example, if Laufey initially has the tag friends, performing tag delete friends will not update the right side panel, even though the tag has been removed from the contact.

Do check out the screenshot for clarity

Rapportbook performs insufficient validation of its data entry fields

In fields such as date of birth, there is no validation done on what constitutes a valid date. For example, a dob of 1 is considered valid.

Other fields such as phone number only do limited validation, for example, the only constraint on a phone number is that it consists of at least 3 numbers. Thus, 123 is considered a valid phone number.

Edit Command Incorrectly shows Error Message: Invalid Format

The command edit 1 dob=1/1/2020 yields an error message, but according to the UG this should be a valid command.

Edit Command incorrectly results in name validation error

It is likely that either the application or the UG is not up to date. As in the UG, it states that po= and dob= are valid parameters for the edit command, however, in the application, the usage message does not include those parameters.

Indeed, the command: edit 1 n=Laufey dob=1/1/2020 yields an error, even though the UG states that this should be a valid command.

It seems that the name parameter seems to be parsing the date of birth as well, thus it thinks that the edited name contains numeric characters.