bellese / angular-design-system Goto Github PK
View Code? Open in Web Editor NEWAngular design system with common use components
License: MIT License
Angular design system with common use components
License: MIT License
Getting an error:
ERROR in node_modules/@bellese/angular-design-system/node_modules/@angular/router/src/router_scroller.d.ts(8,10): error TS2305: Module '"/Users/hl0471/vms/HQR-PR-Webzone/node_modules/@angular/common/common"' has no exported member 'ViewportScroller'.
node_modules/@bellese/angular-design-system/node_modules/@angular/router/src/router_module.d.ts(8,82): error TS2305: Module '"/Users/hl0471/vms/HQR-PR-Webzone/node_modules/@angular/common/common"' has no exported member 'ViewportScroller'.
node_modules/@bellese/angular-design-system/node_modules/@angular/router/src/router_module.d.ts(101,60): error TS2315: Type 'ModuleWithProviders' is not generic.
node_modules/@bellese/angular-design-system/node_modules/@angular/router/src/router_module.d.ts(105,38): error TS2315: Type 'ModuleWithProviders' is not generic.
I believe it's most likely caused by the dependency of angular router 6 when everything else is using 5. I would try to make sure all @angular sanctioned packages use the same version.
angular-design-system/package.json
Line 54 in 2b7c3c7
ngx-charts 8 which is declared as a dependency here is for angular 6. Please declare 7.4 which is the proper version for angular 5
#23 should resolve
since we have gotten rid of the modal element from the table... the button should have the ability to have an id
attribute so we can pass that along in the modal service for focus to return back to that element when the modal is closed.
or option 2 would be to accept an event target instead of the id
in the modal service.
When performing NPM install on this design system, NPM reported multiple security findings from dependencies. I believe some can be resolved by NPM, but a lot of them require manual updating to resolve the issues. @JLLproduction @aproberts01 can you guys take a look and make sure that we can get these findings resolved without breaking changes?
Adding an option to change tooltip so you can add abbreviations to headers.
Currently is very little to no documentation on the proper usage of the modal component. We should add the information needed to correctly utilize this component.
The providers that are being declared in these modules are being initiated everytime an import is happening. Use forRoot to declare the providers so applications just have to initiate once. Refer to: https://medium.com/@chrishouse/when-to-use-angulars-forroot-method-400094a0ebb7
we're seeing a weird ordering in our data with the pipe... sorting: false
.
actual result
array is getting sorted
expected result
no sorting done and object gives items the way it was imported...
angular-design-system/src/app/modules/pipes/sorting.pipe.ts
Lines 11 to 17 in 132f0b1
recommend adding :
if (!event) return items;
right after the line 12
angular-design-system/src/styles.css
Line 20 in 05c212d
is this intended? this increases padding around all ds-l-row
's causing a little less room than the default values.
angular-design-system/package.json
Line 55 in 3fc415f
since we're using angular 7 the compatible version of ngx-charts is version 10
https://swimlane.gitbook.io/ngx-charts/changelog#10-0-0
main
branch failed. π¨I recommend you give this issue a high priority, so other packages depending on you can benefit from your bug fixes and new features again.
You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. Iβm sure you can fix this πͺ.
Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.
Once all the errors are resolved, semantic-release will release your package the next time you push a commit to the main
branch. You can also manually restart the failed CI job that runs semantic-release.
If you are not sure how to resolve this, here are some links that can help you:
If those donβt help, or if this issue is reporting something you think isnβt right, you can always ask the humans behind semantic-release.
package.json
file.A package.json file at the root of your project is required to release on npm.
Please follow the npm guideline to create a valid package.json
file.
Good luck with your project β¨
Your semantic-release bot π¦π
provide ability to input a custom aria label attribute on the <select>
element of the drop down component
A declarative, efficient, and flexible JavaScript library for building user interfaces.
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. πππ
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google β€οΈ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.