bem / bem-components Goto Github PK

View Code? Open in Web Editor NEW

333.0 333.0 89.0 10.58 MB

Set of components for sites development

Home Page: https://bem.info/libraries/classic/bem-components/6.0.0/

License: Other

JavaScript 87.26% Shell 0.33% CSS 8.12% HTML 4.30%

bem components library web-components

bem-components's People

Contributors

Stargazers

Watchers

Forkers

apsavin mishanga belyanskii skywhale-ya sars nataschachu an9eldust aristov fi11 sevinf yurich lavr1k timur4ik l0stsoul mursya vita78 lapinlapin zeloras 4exova incrop gruzzilkin sipayrt qfox slonoed redhedg tavriaforever dayvsonlima remnev f0rmat1k kompolom robot-xliff-farmer b7acksec tyv adinvadim tadatuta doochik vkhv i2r gitter-badger hal0wasted birhoff gela-d ovylehzhanin masterillagithub guria frankie-666 km256 alexeimoisseev mixalezhnev vsesh frontendbro paranoics skad0 rvwdude belozer lisbon11 konstantinklepikov dmkcode roman-murashov marfuzzi akashfoss rtemision tauka koloskof pebsconsulting csscheck realetive sanaglx philsimmonds emtee40 vaivaivai dmitriys87 logic21 barkarula tayou-sun b1tc0re doc22940 ar1es fual jagarinart cheremiskin wnakswlsla galichy79

bem-components's Issues

input_type_textarea: __box must be div

Eliminate copy-paste about `_isControlFocused`

For example we can use BEM.declMix.

cc @dfilatov

Write maintainers list to README.md

Use new pointer-events block from bem-core

cc @deepsweet

Сonsider unifying `radiobox` and `radio-button` as one block with modifiers

Right now there is a lot of copy-paste in BEMHTML for those blocks and not so much differences in JS.

cc @lento4ka @dfilatov @gela-d @narqo @Toivonen

button_checkable: add checkable button

button: Refactoring API

Simplify BEMJSON and JS API for button block.
cc @dfilatov

button: try to get rid of `only-icon` mod

Based on #158

There is a lot of CSS in library that pretend to be "design free"

cc @lento4ka @gela-d @tadatuta @dfilatov

Delete `dev` branch after merging all pull-requests

Rename bem-controls to bem-components

Модификатор only-icon вызывает ошибку

В bemhtml.js раскрывается как this.mods.only - icon и bem make падает с ошибкой icon is not defined.

bem -v
0.5.24

input.bemhtml: Shortcut for `content: { elem: 'control' }`

In case of simple content like content: { elem: 'control' } we can treat empty content as { elem: 'control' }.

Here is "patch":

block input, content, !this.ctx.content: { elem: 'control' }

Не выставляется модификатор _side_both

Так не выставляется:

{
    block: 'radio-button',
    content: {
        elem: 'radio',
        content: 'abc'
    }
}

Так выставляется:

{
    block: 'radio-button',
    content: [{
        elem: 'radio',
        content: 'abc'
    }]
}

input: Could not specify localized input as value from BEMJSON

{ block: 'input', mods: { size: 's' }, name: 'my-name', value: {
    block: 'i-bem', elem: 'i18n',
    keyset: 'my-keyset', key: 'my-key'
}, content: { elem: 'input' } }

input: split `val` method into 'setVal' and 'getVal'

input: Remove all about samples

Remove: __sample, __samples, _has-sample

Because of using ymodules system there is no more need in most of `mustDeps` usage

Configure precommit hook for tests

If we try to commit some BEM-item with tests, we should run it in precommit hook.

Use tests and examples infrastructure

We can use configs like in bem-core.

cc @dfilatov

attach: Refactoring API

Simplify BEMJSON and JS API for attach block.
cc @dfilatov

Research the possibility to use css pseudostyles in button for radio groups

cc @mishanga

Убрать остатки внешнего вида из контролов

Сейчас есть всякие остатки от внутреннего дизайна, например:

галочка в checkbox
крестик в attach и input
иконка файла в attach
...

Наверное, это не совсем честно и нужно сделать bem-controls ещё более обезличенными.

cc @tadatuta @lento4ka @dfilatov

Сonsider unifying `checkbox` and `check-button` as one block with modifiers

Right now there is a lot of copy-paste in BEMHTML for those blocks and not so much differences in JS.

cc @lento4ka @dfilatov @gela-d @narqo @Toivonen

link: move pseudo-specific behavior to corresponding mod

Стоит хотя бы одному блоку link поставить js: true, все остальные ссылки тоже подключают js, и как следствие не работает дефолтный переход по href. Наверное стоит убрать js в модификатор pseudo как было в bem-bl

input__control: Preserve styled borders in i-ua_js_no mode

ie < 9 bug in radio.js v2

IE меньше 9 ругается на true, должно быть строка или число.

beforeSetMod : {
        'focused' : {
            true : function() {
                return !this.hasMod('disabled');
            }
        }
    }

this.bindTo(this.domElem, 'change', function(e) { // this.domElem is form
    this.trigger('change');
});

as you know dom elems, like input trigger it's change only on blur, bem inputs has cool mechanism to solve that problem.
so my advice is to add this.elem('control').change(); after this bem change trigger: https://github.com/bem/bem-components/blob/v1/common.blocks/input/input.js#L71

checkbox: Refactoring CSS

Use more JetBrains IDE's friendly jsdoc annotations

According to this issue in jetbrains issue tracker, it's better to use

/**
 * @class Button
 * @extends BEM.DOM
 */
BEM.DOM.decl('button', /** @lends Button */ {
    // Button code
}, /** @static Button */{
   //static Button methods
}

then @namespace, like now.
I can make a pull request with changes in jsdoc, if you agree.