benali-samar/vlog-buddie

Video capture for vlogging

A little more about me...

• I am an Embedded Linux Developer, interested in yocto build system and Linux device drivers development.
• I’m working on system programming, yet struggling to understand the linux kernel :/
• Passionated with planet Saturn, galaxies, Black holes and space ^^
• Reach me with: [email protected]|[email protected]

  

Languages and Tools :

Thanks for Visiting!

vlog-buddie's Issues

possible NULL pointure

line 62
buffers = calloc(req.count, sizeof(*buffers));
you miss to check for possible NULL pointer .

Possile inf loop

while (1) {
int ret = poll(poll_fds, 1, 1000); // wait up to 1 second for events
// ( put -1 if it should wait forever )
if (ret < 0) {
perror("Failed to poll");
exit(1);
} else if (ret == 0) {
printf("Poll timeout\n");
continue;
}

    if (poll_fds[0].revents & POLLIN) {
        // Dequeue the video buffer for sending it to the output/display
        struct v4l2_buffer buf = {0};
        buf.type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
        buf.memory = V4L2_MEMORY_MMAP;
        if (ioctl(fd, VIDIOC_DQBUF, &buf) < 0) {
            perror("Failed to dequeue buffer");
            exit(1);
        }

        // Write the video data to the output device
        write(out_fd, buffers[buf.index].start, buf.bytesused);

        // Enqueue the video buffer again
        if (ioctl(fd, VIDIOC_QBUF, &buf) < 0) {
            perror("Failed to enqueue buffer");
            exit(1);
        }
    }
}

in this peace of code there's no break point to continue the rest of code .
we see only exit .it will stop code from running need to double check this