benfreke/oc-menumanager-plugin

A Menu Management Plugin for October CMS

oc-menumanager-plugin's Issues

I18N and L10N

I'm developing E-commerce system with October and using this plugin. If you can add lang folder and make texts and inputs dynamic -takes only 5-10 mins.- this plugin will be very useful. I can help editing the plugin btw. Thanks.

Undefined property when creating menu item

I've installed octobercms using composer (git version) and installed the menu manager. Unfortunately I get an error when I try to create a new menu item:

Undefined property: Backend\Classes\FormField::$columnName

Any hints?

components/Menu.php $baseFileName = $this->page->page->getBaseFileName();

Call to a member function getBaseFileName() on a non-object
$baseFileName = $this->page->page->getBaseFileName();

Depricated since Build 260 (2015-05-16)???

The |page filter now supports passing an empty string to generate a link to the current page.
Component variables set with $this->page no longer leech in to other component partials.

Menu is not show on the theme

I have added the menu to a page and configured all the menu links from a menu tab. The menu is not appearing on the webpage

and i dump {{ dump(parentNode.getChildren) }} but the value is null (0)

please help me ..thank you

Incorrect URL paths

One other thing I've just noticed, say you were to link the "Blog" page to the nav, it is now pulling through the full page url ie /blog/:page? instead of just /blog - I'm pretty sure it didn't do this before?

Also, if you're using October via a sub-directory e.g in MAMP, so your site url would be http://localhost:8888/october/ for example, the home url is obviously /, but that doesn't work now as / goes to http://localhost:8888 when it should go to /october, and therefore all other urls in the menu now go to http://localhost:8888
e.g
http://localhost:8888/blog instead of http://localhost:8888/october/blog - if that makes sense?

Again, I'm pretty sure it didn't do this before?

Dropdown menu is rendered when subpage is disabled

When there is a single disabled subpage in a menu item , the dropdown menu is being rendered empty.

[Extra Features] URL parameters & Query string

Have also added functionality to pull in additional URL parameters e.g

If you want to link to a specific blog post which as a page url of /blog/post/:slug, you can now pass the parameters as a JSON string like {"slug":"my-post-slug"}.

You can now also pass an extra query string option which is appended to the URL, just in case anyone needs that extra feature :)

Again, once pull request #16 is merged....

Extra URL parameters issue

I'm seeing a problem with the "Extra URL parameters".
I am using the { 'slug' : 'slugvalue' } format for the "Extra URL parameters" field but the URL always gets set to:

'url/default'

instead of

'url/slugvalue'

Any help would be appreciated. Thanks!

Localise all files

Because not everyone speaks English.

Cannot access protected property Backend\Widgets\Form::$allFields

octobercms/october@f99bd0e made the field protected. Can't provide a PR atm, sorry!

url field does not save

October Build 238. Both internal and external menu types does not save url.

Still receiving node error

After updating to latest settled OctoberCMS build (107) and updating your plugin to v1.0.5, I'm still getting the error:
A node cannot be moved to a descendant of itself.
every time I try to re-order the menu items?

Allow component to be inserted by drag and drop

There looks to be new code that is needed for this

Bring "enabled" state into model getChildren

This requires a fair chunk of change, as we'll need to update counts as well. Currently we getAllChildren of the topNode, but we need to change that to be just the active nodes.

Likewise, we're currently using childrenCount but will need to do a count(getAllChildren) once we've enabled the "enable" flag on the get method

Allow url fragments in menu items

Use the core of nnmer-path-2 branch. Should be a one line fix.

Display the page title in the menu listing page

Because the file name on it's own is not very helpful

Reorder_toolbar not found.

In Controller menus.php the reorder method looks for:

~/benfreke/menumanager/controllers/menus/_reorder_toolbar.htm
See: https://github.com/benfreke/oc-menumanager-plugin/blob/master/controllers/Menus.php#L70

This causes following error:

[Feature Request] Enable/disable menu items

Maybe just a checkbox/switch on the menu item to enable/disable that item, whilst still keeping it in the actual menu, just removing it from public view?

Template chooser for menu

As Bootstrap is getting close to a version 4 release, the code has changed. Provide a way to use multiple templates, not only for the entire site but on a component by component basis

multiple menus

I can't see a way of adding multiple menus - can I add this as a feature request??

Thanks!

Standardise menu item options

Some are booleans, some are radios, some are switches. Visually, I want them to look as similar as possible.

Menu items are shown based on frontend permissions

In case the user does not have access to a certain page, the link is not displayed.

Plugin broken after update to current CMS Build 146

Error on new Menu creation:

The partial '.../modules/backend/widgets/form/partials/_field_text.htm' is not found.
.../modules/backend/traits/ViewMaker.php line 62

EXCEPTION

System\Classes\SystemException

        $partial = '_' . strtolower($partial) . '.htm';

    $partialPath = $this->getViewPath($partial);

    if (!File::isFile($partialPath)) {
        if ($throwException)
            throw new SystemException(Lang::get('backend::lang.partial.not_found', ['name' => $partialPath]));
        else
            return false;
    }

    return $this->makeFileContents($partialPath, $params);
}

[Exception Error] Error after update to CMS build 107

Hi, now getting this error after update to build 107:

This looks to be a CMS error, but I'm getting it through your plugin when I try to re-order the menu items, so not sure if you'd like to raise it?

Menu component break on update october build 270

xception 'ErrorException' with message 'Trying to get property of non-object' incomponents/Menu.php:125
Stack trace: #0

$baseFileName = $this->page->cmsObject->page->getBaseFileName();

Allow empty separator menus

These can be done easily in Bootstrap. Provide a way to do this

Menu is not appearing on the frontend

I have added the menu to a page and configured all the menu links from a menu tab. The menu is not appearing on the webpage. What may be the issue.

Extra dynamic parameter for li > a elements

Hi Ben,

It's a very useful plugin!
Is it possible to add extra dynamic parameter e.g. "listItemLinkClasses" which will add custom classes(es) to the li > a element of the menu items?

Thank you,
Nikolaos

Move link creation out of twig template

This will allow me to add additional parameters to the url if needed, say for a blog category.

Automatically update page links

Find out if there is an event I can hook into that will tell me when a baseFileName changes, and update any references to it.

Unable to find configuration file

Hi
after install i get this error

Unable to find configuration file /var/www/plugins/plugins/benfreke/menumanager/models/menu/columns.yaml defined for Backend\Behaviors\ListController.

/var/www/modules/system/traits/ConfigMaker.php line 63

Postgres Support

Hi,

while trying to install the menu manager via the backend, I got the following error message:

SQLSTATE[42601]: Syntax error: 7 ERROR: syntax error at or near "`" LINE 1: ALTER TABLE `benfreke_menumanager_menus` MODIFY `nest_left` ... ^ (SQL: ALTER TABLE `benfreke_menumanager_menus` MODIFY `nest_left` INTEGER UNSIGNED NULL;)" on line 666 of /Applications/MAMP/htdocs/octobercms/vendor/laravel/framework/src/Illuminate/Database/Connection.php

It seems that it's "the same" as #52

Label of the component properties are wrong

see this

I have error when set Active Node to default

I have error when set Active Node to default

Call to a member function getBaseFileName() on a non-object
// Go and find the page we're on
$baseFileName = $this->page->page->getBaseFileName();

Translatable external URL

CONTEXT:
multilanguage website managed with Rainlab.Translate

NEEDS:
menu items liked to external URL could have different href depending on current locale:

• IT => google.it
• ES => google.es

Simply add external_url and url to $translatable fields

oc-menumanager-plugin/models/Menu.php

Line 29 in d7b9ccc

public $translatable = ['title', 'description'];

is not sufficient due to how internal/external URL values are saved (unique url attribute plus is_external flag).

Do you think you can support that?

In the meanwhile, the only workaround that I see is to use a CMS page to manage a "redirect router" somehow. Any other ideas?

SQLite Support

As per this forum post, the way the migration has been created prevents this from working with SQLite.

Re-write it so it works with all supported database drivers.

syntax error

Hi,
after install i get this error
syntax error, unexpected '/', expecting variable (T_VARIABLE) or '$' /var/www/plugins/benfreke/menumanager/controllers/Menus.php line 70
i can't access to menu panel

[Feature addition] Inline component "parent node"

Add functionality to enter inline parent node to allow multiple different menus on same page, and maybe different menus on different pages whilst using the menu component at layout level e.g

{% component "menu" parent="Top Nav" %}

{% component "menu" parent="Footer Nav" %}

sql error

hi,when i add a new item to the menu.i got this error,please help,thank you!
"SQLSTATE[42S22]: Column not found: 1054 Unknown column 'internal_url' in 'field list' (SQL: insert into benfreke_menumanager_menus (title, description, enabled, is_external, internal_url, external_url, link_target, parameters, query_string, url, nest_left, nest_right, updated_at, created_at) values (asd, , 1, 0, , , _self, , , , 1, 2, 2015-02-21 06:46:15, 2015-02-21 06:46:15))" on line 614 of D:\xampp\htdocs\octobercms\vendor\laravel\framework\src\Illuminate\Database\Connection.php

Add ability to link to external sites

Because not every link should be a page

How to make menu appear on mobile dropdown navigation menu?

I created two new menu items with this plugin. It's working perfectly on the desktop site.

However, those new menus are not visible on mobiles and tablets. How do I fix that?

Add class to anchor tag

It would be really helpful to have the possibility to add classes to the anchor tag of the menu items.

The reserved indicator "@" cannot start a plain scalar

The reserved indicator "@" cannot start a plain scalar; you need to quote the scalar at line 9 (near "form: @/plugins/benfreke/menumanager/models/menu/fields.yaml").
/home/pooperpumper/public_html/vendor/symfony/yaml/Inline.php line 259

Reorder one menu item

HI!
Thanks for your plugin.
I've reached a bug, when trying to reorder one item of the menu
"A node cannot be moved to a descendant of itself." on line 928 of /Users/bardack/www/parasport/vendor/october/rain/src/Database/Traits/NestedTree.php

Add bootstrap dropdown options

See http://getbootstrap.com/components/#dropdowns-example for examples.

Although it's not only used by bootstrap, the ability to have classes on the list item should extend the functionality of the plugin.

[Suggestion] Active class on Home

Thanks for adding the .active class to the plugin. Slight issue, if you have a link to home page or / the link doesn't get the active class.

How to delete menu?

The question in the title.

Do not create Controller instance every time getLinkHref is called

Hi,

is there any reason of not doing this

$this->controller = BaseController::getController() ?? new BaseController();

instead of this?

oc-menumanager-plugin/models/Menu.php

Line 165 in 9467eda

$this->controller = new BaseController;

Now it creates router instance (and other stuff) every time \BenFreke\MenuManager\Models\Menu::getLinkHref is called.

Add twig blocks for output

This should result in cleaner code in the default partial, as well as increased flexibility in modifying partials down the track

"Method validateJson doesn't exist" problem

Hi,

I have a problem with extra url parameters with json. When I'm trying to save it says that "method validateJSON doesn't exist". I look at Pages plugin's validation and made how they made. Now it saves, but with no validation.