benhall14/php-calendar

A simple PHP class to generate calendars. Easy to populate, the calendar shows events by passing in an array.

php-calendar's Issues

error draw calendar

Hi,

i'm trying to draw simple calendar with this code :
<?php $calendar = new Calendar(); echo $calendar->draw(date('d-m-Y')); ?>
but i've that error :
Fatal error: Uncaught Error: Call to a member function modify() on boolean in C:\xampp3\htdocs\zimbra_admin\vendor\benhall14\php-calendar\src\phpCalendar\Calendar.php:138 Stack trace: #0 C:\xampp3\htdocs\zimbra_admin\contatore.php(20): benhall14\phpCalendar\Calendar->draw(false) #1 {main} thrown in C:\xampp3\htdocs\zimbra_admin\vendor\benhall14\php-calendar\src\phpCalendar\Calendar.php on line 138

how can i fix?

Event Filtering Issue Based on Time Comparison, Resulting in Incorrect Exclusions"

When i add events that are only like 2 hours long e.g.

start 2023-12-24 14:00
end 2023-12-24 16:00

They are not shown when i use the script after 16:00

The issue lies in the comparison of timestamps within the findEvents function. The comparison of timestamps for events uses both date and time, causing events that occur on the same day but at different times to be improperly filtered out.

To rectify this, I modified the function to focus solely on the date part of the timestamps for comparison, disregarding the time component. This was achieved by extracting and comparing only the dates (in the format 'Y-m-d').

Here's the problem demonstrated:

`
private function findEvents(DateTime $date)
{
$found_events = array();

if (isset($this->events)) {
    foreach ($this->events as $event) {
        // Comparison that considers both date and time
        if ($date->getTimestamp() >= $event->start->getTimestamp() && $date->getTimestamp() <= $event->end->getTimestamp()) {
            $found_events[] = $event;
        }
    }
}

return $found_events ?: false;

}

`

and here is the corrected version

`private function findEvents(DateTime $date)
{
$found_events = array();

if (isset($this->events)) {
    foreach ($this->events as $event) {
        // Extracting and comparing only the dates (Y-m-d) to avoid time-based exclusion
        $eventStartDate = (new DateTime($event->start->format('Y-m-d')))->getTimestamp();
        $eventEndDate = (new DateTime($event->end->format('Y-m-d')))->getTimestamp();
        $inputDate = (new DateTime($date->format('Y-m-d')))->getTimestamp();

        if ($inputDate >= $eventStartDate && $inputDate <= $eventEndDate) {
            $found_events[] = $event;
        }
    }
}

return $found_events ?: false;

}
`

This modification ensures that the comparison focuses solely on the dates of events and input, disregarding the time part. This way, events occurring on the same day will be appropriately included irrespective of the specific times they occur.

more than one event per day

How can we make it so that if there is more than one event it shows on serperate lines as currently it shows all on one line

controller code

$calendar = new Calendar;
      $calendar->addTableClasses('w-full h-full');
      $calendar->stylesheet();
      $events = array();
      $shifts = ShiftModel::all();
      foreach ($shifts as $shift) {
          $events[] = array(
              'start' => $shift->start_time->format('Y-m-d'),
              'end' => $shift->end_time->format('Y-m-d'),
              'summary' => $shift->name,
              'mask' => true
              );
  }
  

  $calendar->addEvents($events);

View Code
echo $calendar->draw(date('Y-m-d'),

Title attribute on events doesn't escape HTML tags

Hi,

First of all thanks for your library :)

I got a user reporting a bug to me which is that the tooltips that appear when hovering over an event has escaped HTML displayed if the event has html injected in it (in my case, a <br> line break). See the screenshot:

I have a local patch, I'll make a PR.

Cheers
Pascal