Giter Site home page Giter Site logo

Comments (10)

bensampaio avatar bensampaio commented on July 29, 2024

@bullwinkle which version of webpack are you using? I don't have this problem, but apparently both options and _compilation were deprecated so your solution would also not be future proof. I will look into this.

from external-svg-sprite-loader.

bensampaio avatar bensampaio commented on July 29, 2024

I opened a question on StackOverflow: http://stackoverflow.com/questions/43373376/how-to-access-the-webpack-config-with-the-new-loader-api.

from external-svg-sprite-loader.

bullwinkle avatar bullwinkle commented on July 29, 2024

First of all i want to say that this is a helpful tool and thank you for your work.
webpack "version": "2.3.3"
I can't find information about deprecating _compilation. Seems it is a usable solution.
https://webpack.js.org/api/loaders/#this-_compilation

from external-svg-sprite-loader.

bensampaio avatar bensampaio commented on July 29, 2024

If you go a bit up in that page you will see the following header: Deprecated context properties

from external-svg-sprite-loader.

bullwinkle avatar bullwinkle commented on July 29, 2024

ah, yes, you are right :)) so, we need an alternative solution... maybe ask Sokra ?

from external-svg-sprite-loader.

bensampaio avatar bensampaio commented on July 29, 2024

I would say an alternative solution would be to pass the publicPath as an option to this loader. But maybe there is another way to do this now and that's why those properties are being deprecated. How do you propose I contact Sokra? Questions don't seem to be allowed on the webpack repo and Sokra has no contact information. Maybe you can upvote my question on StackOverflow so it gets more visibility? :)

from external-svg-sprite-loader.

bullwinkle avatar bullwinkle commented on July 29, 2024

@sokra, please, look at this problem. Needs a proper way to get data from deprecated options or _compilation inside loader.

from external-svg-sprite-loader.

mattybow avatar mattybow commented on July 29, 2024

posted a possible solution here http://stackoverflow.com/questions/43373376/how-to-access-the-webpack-config-with-the-new-loader-api/43532591#43532591

from external-svg-sprite-loader.

bensampaio avatar bensampaio commented on July 29, 2024

This should be fixed on v2.2.1. Let me know if that's not the case :)

from external-svg-sprite-loader.

bullwinkle avatar bullwinkle commented on July 29, 2024

Will be great :)

from external-svg-sprite-loader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.