Comments (11)
@timbomckay this should be possible. I'll try to have a look into it when the problem in #54 is resolved.
Remind me about this if I don't come back to you :)
from external-svg-sprite-loader.
Thanks @bensampaio. If it's already a feature just let me know how to pass that option. Haven't seen it in the documentation.
from external-svg-sprite-loader.
Just to make sure: the <view />
elements are necessary if you use the sprite icons in CSS. Are you not using them in CSS?
from external-svg-sprite-loader.
Correct we're not using the CSS feature. It's nice to have and we can opt into it if we ever decide to but it's unnecessary space for right now.
Version: "external-svg-sprite-loader": "3.4.1",
Settings:
rules: [
{
test: /\.js$/,
use: { loader: 'babel-loader' },
exclude: /node_modules/
},
{
test: /collection-1\\[a-zA-Z0-9_-]*.svg$/,
loader: 'external-svg-sprite-loader',
options: {
name: 'collection-1.svg',
iconName: '[name]'
}
},
{
test: /collection-2\\[a-zA-Z0-9_-]*.svg$/,
loader: 'external-svg-sprite-loader',
options: {
name: 'collection-2.svg',
iconName: '[name]'
}
},
{
test: /collection-3\\[a-zA-Z0-9_-]*.svg$/,
loader: 'external-svg-sprite-loader',
options: {
name: 'collection-3.svg',
iconName: '[name]'
}
}
]
Thanks
from external-svg-sprite-loader.
Ok, I get it. The problem is: the main reason that lead me to create this loader and plugin was because there was no other that supported CSS. So this request is a bit unexpected 😛 Anyway, it could be done but I'll need to give it some thought. Most probably I would add this in a minor version of v4, so first I'll focus on releasing v4.
from external-svg-sprite-loader.
Ok. Yeah we just use it as <svg><use href="external.svg#icon" /></svg>
. Didn't know if there was a way to just pass a rule like
options: {
name: 'collection-1.svg',
iconName: '[name]',
view: false
}
Thanks for creating the loader, it's been a big help.
from external-svg-sprite-loader.
Currently there is no such option. Maybe one option would be using SVGO to remove the views but for now you would need to do this yourself.
from external-svg-sprite-loader.
Ok. But you were saying you're gonna implement that option for a 4.x release?
from external-svg-sprite-loader.
I will look into it since I'm not sure if this is possible.
from external-svg-sprite-loader.
Hi @bensampaio, when do you think you'll have some feedback on this?
from external-svg-sprite-loader.
Not soon, sorry. I have several other things to focus on at work. If you have an idea on how to implement this let me know what you have in mind. I'll try to come back to this in December.
from external-svg-sprite-loader.
Related Issues (20)
- Clearer errors when trying to use the latest version with Webpack 4
- Duplicated IDs in icon sprite
- angular13 not generate sprite file
- It doesn't work with webpack 5 cache=filesystem
- SVGO Options HOT 4
- "TypeError: loaders is not iterable" after upgrade to v4 HOT 8
- Odd behavior when generating a manifest file HOT 8
- consistency with others loaders in manifest.json HOT 4
- Error when defining Rule.use as a function HOT 2
- Using `webpack-chain` breaks default options HOT 1
- It doesn't generate svg sprite HOT 17
- The module removes "fill" attribute when converting to symbol HOT 2
- Alternative (simpler) way to address the images inside the sprite (no math) HOT 1
- deprecation warning for chunk.files in webpack 5 HOT 1
- The sprite status is blocked: origin (webpack --mode production) HOT 23
- Can't run in storybook
- Deprecation warning for Chunk.modulesIterable
- Breaks with [email protected] HOT 3
- SvgStorePlugin fails if there are any other unrelated errors in the build HOT 1
- Support and compatibility with Webpack 4 regarding mini-css-extract-plugin HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from external-svg-sprite-loader.