Giter Site home page Giter Site logo

explorebolero's People

Contributors

benttranberg avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

explorebolero's Issues

Bug affecting navbar dropdown when using Bulma 0.7.5 in Edge on Win 10

There are issue reports explaining details about this, but I don't have time to retrace my research right now. The workaround is simply not to upgrade beyond Bulma 0.7.4 until somebody produces a fix somewhere, and preferably in Bulma itself so that the fix is backwards compatible with even slightly old Edge browsers due to machines not being online and updated.

Add burger to navbar

This requires some code that I have elsewhere and will port. The code will toggle active on navbar and menu.

Use of NodaTimePicker needs code review

I don't know for sure if the wrapper for the NodaTimePicker is implemented correctly and used correctly.

When upgrading from preview-7 to preview-9, there was one problematic change that I finally found a solution to by simply googling and experimenting a lot, but without really understanding more than a tiny fraction of what's going on. That change was with how OnSelected is used. Is the solution I arrived at the correct one?

Dotting at OnSelected reveals an OnSelected.InvokeAsync, and I'm wondering why that isn't part of the solution I arrived at. Should it be?

Use Bulma Hero in combination with Bulma navbar

Use Bulma Hero in combination with Bulma navbar, as explained in the documentation for Bulma Hero. Looks like this will give better control of the overall top level layout, including an alternative for a footer.

Buttons in navbar for Login and Register

There are currently only the Tweet and Download buttons originally in the Bulma demo snippet. I have code elsewhere for Login that needs porting, but no code for registering.

Further improvements related to use of PageModel

ExploreBolero uses PageModel for pages that are siblings.

I'm thinking that these pages can be handled by a subrouter of the main router. This is explained somewhere - an issue in Bolero, or somewhere else.

Also, in Main.fs there are currently cases in a number of places - in update, in defaultModel, in menuItem, in .Menu and in .Body - and these can perhaps also be collapsed into something, in order to move closer to single point of responsibility.

What then is the way forward? Should all of this be wrapped by a single submodel for maximum cleanliness, or should it be done in the main model? Should part of it be done in the main model first, and then moved to a wrapping submodel?

The books model is also one of those sibling pages, but was not handled by the old page model system, and so is not yet moved into the new system either. Will do.

The home page is one of the sibling pages, but not included in the PageModel based stuff. Should it be?

Look at efficiency of message handling in submodels

The application seems to get slower for each submodel added.

Compare this

https://github.com/BentTranberg/ExploreBolero/blob/master/ExploreBolero.Client/Main/Main.fs

with this

https://github.com/elmish/Elmish.WPF/blob/master/src/Samples/SubModelOpt/Program.fs

I'm thinking that all the submodels in Main.fs will cause a lot of traversing, and perhaps they should be option, and None when not displayed.

Or maybe all the page submodels should not even be there. Maybe there should only be one page submodel in the main model, which fans out with the help of a DU or class hierarchy or something.

Maybe the similar looking match cases for the submodels can be removed from Main.fs. Any deviation can perhaps be handled in an override with call to base, or some other equivalent functional solution can be made.

Try out and see if such a change will make the application react faster. Just make the first attempt simple, with option and None.

Change the point where burger appears in navbar

Do I really have to go through the pain of modifying Bulma variables in order to achieve this? Perhaps I'll ask for a feature request in the Bulma repo, unless an easy solution can be found. Lots of other people struggle with the same issue, so a feature request definitely has a chance to be accepted.

Problem using Bulma Extensions DatePicker

I haven't succeeded in getting Bulma Extensions DatePicker to work. Instructions on use is on the following page.

https://creativebulma.net/product/calendar/demo

There are steps on that page which doesn't seem relevant to my use. I only include the css and js files in index.html.

Perhaps I failed to understand what I need to do with the javascript snippets found on that page. I can't even get the component to replace the browser's built in date picker.

I have added the javascript that I think is needed, in this file: https://github.com/BentTranberg/ExploreBolero/blob/master/ExploreBolero.Client/Dates/dates.html

I have also tried to put that javascript elsewhere, to no avail.

The relevant changes are in this commit : 56ee01a

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.