benwatts/shopify-theme-radiance

A Shopify Theme

shopify-theme-radiance's Issues

#Umbrella box is too far down and padding is off and bottom box crops off text

Problem

umbrella div is down the page on Firefox/Chrome/IE and 4px cropped off top.

bottom div cuts off the copyright and powered by text in Firefox/Chrome/IE

Suggested Fixes (Tested in Firefox/Chrome/IE/Safari )

For #umbrella change padding and top to:
padding: 4px 10px 0 12px;
top: -16px;

For #bottom change padding to:
padding: 35px 20px;

Responsive

Hi,

Any chance to make it responsive?

Thanks

Meta Description for index.liquid loads missing setting

Problem

Theme attempts to load settings.site_description for meta data when on the index page, but that setting doesn't exist.

Location: theme.liquid line 17

Suggested Fixes

1. Change to shop.description to load the description from Preferences > General Settings. (involves the least changes)
2. Add the setting to settings.html and provide a blank default in settings_data.json

Recent | escape removal - not on all?

Hi - i've been referring to this project as i'm working on a theme, and I noticed that you recently removed a lot of the | escapes from the liquid filters? (commit: d3ce50f ) But not all of them - Especially on the Layout.liquid file ? Is there a reason for this?

I was just about to do a global find and replace to remove all '| escape' references - should i not do that?