berava/colmar-academy

Capstone project in Build Websites from Scratch intensive course of CodeCademy

colmar-academy

colmar-academy's Issues

Ampersand character (&)

colmar-academy/index.html

Line 74 in b2c7a34

<h3>Tue 10/11 & Wed 10/12:8am-3pm</h3>

Use the reserved html entity for the ampersand character (&)

Read more about html entities here: https://developer.mozilla.org/en-US/docs/Glossary/Entity 👍

Thesis exhibit section

The thesis exhibit section, right side container, can improve the flexbox by removing the centering property

Summary

Overall Exceeds Expecations.
Hey Berava great work on your project Colmar Academy
About Linking:
Looking over your code I can see that you used good html structure as well as css.
Your css is linked to the html page and uses an appropriate file path, also you used proper image and anchor links
About Structure:
Your documents both have good hierarchy for the page structure, your css is a cascading stylesheet, so anything written at the bottom of the page will be applied/recognized therefore overriding a previous style written above it.
The html structure has a nice use of divs and parent elements to group smaller and appropriately sectioned elements. This is known as nesting elements within the parent, or wrapping children elements within a container.
About Syntax:
Syntax is our grammar and spelling of code, if there are any errors in your code it would show in your browser and can negatively affect the desired outcome. There were little to no errors in your code but i encourage you to always take more time to revise for errors (code checking is how we spend half our time 😆 ).
Ok - Great work overall Berava I suggested some things to bookmark or simply keep in mind to improve your project:
For your editor of choice, include a linter (a syntax-checker) for your coding language, this will save you hours if not days of work!! 😋
Also I encourage to check out this excellent article on file paths and linking 👍
https://www.kirupa.com/html5/all_about_file_paths.htm
Lastly keep some HTML/CSS best practices in mind when coding
http://www.scottohara.me/htmlcss
When in doubt Google it (or MDN it) 🎉

Courses section

You can reduce the padding for the offered courses section when the media query is reduced

Great choice of font

Great choice of font very welcoming and playful, clear commenting in your documents and maybe suggested border radius applied to all images or div card with a value 3px

Good use of box-shadows and hover classes, i got a lot of feedback and interaction from this page

NOTE: Always conduct...

NOTE: Always conduct a peer review with your peers in Slack, this will improve performance and ability to problem solve! 💯

Classnames

Some areas showed inconsistent spacing between child and parent elements for example, the information section and the thesis section,

Both right side div containers have children elements with class media-container within the news parent element….

This can be more consistent with their sibling elements if they share the class name small-media-container