berendeanicolae/tetris

tetris's Issues

Resources

Place the resources here on github, don;t provide an external link for them, nobody will bother checking out your game if it's hard to compile and run...

Right shifts for division

My advice would be not to use right shifts for division:
board_x=(screen->w-(boxh+1)*width+1)>>1;

It makes your code ureadable, I had to actually test what that does, which is not good for someone reading your code.

Game::play and obvious comments

Game::play is a way too big method, I think it coudl be split up in somethign more readable, at least those initialization and clean-up parts.

Also you have comments like: //Variables or //Methods, these are useless, I recommend you get rid of them and read about docblocks instead (search for Doxygen after you've read about docblocks).

Makefile

I saw that you give instructions about compiling in the readme.
This is ok, but I recommend reading about Makefiles and make, with this you can automate the compiling part and you'll only need to give instructions on how to run & use the game, not compile it.

SDL_INIT_EVERYTHING

I doubt you need everything, because I couldn't find SDL_Joystick or SDL_CD in your source...

Don't init everything, you'll save some resources.

Show me the next tetrimino

Being some kind of tetris fan myself, I'd like to see which tetrimino comes next so I can plan where to put the current tetrimino in order to fill some lines, it's rather hard to play tetris knowing only the current tetrimino.